btrfs: balance: use redundancy instead of integrity

Commit Message

Anand Jain Sept. 25, 2019, 6:29 a.m. UTC

When balance reduces the number of copies of data it reduces the
redundancy, use the term redundancy instead of integrity.

Signed-off-by: Anand Jain <[e-mail]>
---
 fs/btrfs/volumes.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

Comments

David Sterba Sept. 25, 2019, 4:45 p.m. UTC | #1

On Wed, Sep 25, 2019 at 02:29:28PM +0800, Anand Jain wrote:
> When balance reduces the number of copies of data it reduces the
> redundancy, use the term redundancy instead of integrity.

I agree, patch on the way to misc-next. If anybody has concerns or
further clarifications, please speak. Thanks.

Patch

diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
index 5d35f3f34bd2..9ce975f1ddee 100644
--- a/fs/btrfs/volumes.c
+++ b/fs/btrfs/volumes.c
@@ -4032,7 +4032,7 @@  int btrfs_balance(struct btrfs_fs_info *fs_info,
 	int ret;
 	u64 num_devices;
 	unsigned seq;
-	bool reducing_integrity;
+	bool reducing_redundancy;
 	int i;
 
 	if (btrfs_fs_closing(fs_info) ||
@@ -4109,9 +4109,9 @@  int btrfs_balance(struct btrfs_fs_info *fs_info,
 		    ((bctl->meta.flags & BTRFS_BALANCE_ARGS_CONVERT) &&
 		     (fs_info->avail_metadata_alloc_bits & allowed) &&
 		     !(bctl->meta.target & allowed)))
-			reducing_integrity = true;
+			reducing_redundancy = true;
 		else
-			reducing_integrity = false;
+			reducing_redundancy = false;
 
 		/* if we're not converting, the target field is uninitialized */
 		meta_target = (bctl->meta.flags & BTRFS_BALANCE_ARGS_CONVERT) ?
@@ -4120,13 +4120,13 @@  int btrfs_balance(struct btrfs_fs_info *fs_info,
 			bctl->data.target : fs_info->avail_data_alloc_bits;
 	} while (read_seqretry(&fs_info->profiles_lock, seq));
 
-	if (reducing_integrity) {
+	if (reducing_redundancy) {
 		if (bctl->flags & BTRFS_BALANCE_FORCE) {
 			btrfs_info(fs_info,
-				   "balance: force reducing metadata integrity");
+			   "balance: force reducing metadata redundancy");
 		} else {
 			btrfs_err(fs_info,
-	  "balance: reduces metadata integrity, use --force if you want this");
+	"balance: reduces metadata redundancy, use --force if you want this");
 			ret = -EINVAL;
 			goto out;
 		}