| Message ID | 20190927174218.GA32085@huvuddator (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/tiny: Kconfig: Remove always-y THERMAL dep. from TINYDRM_REPAPER | expand |
Den 27.09.2019 19.42, skrev Ulf Magnusson: > Commit 554b3529fe01 ("thermal/drivers/core: Remove the module Kconfig's > option") changed the type of THERMAL from tristate to bool, so > THERMAL || !THERMAL is now always y. Remove the redundant dependency. > > Discovered through Kconfiglib detecting a dependency loop. The C tools > simplify the expression to y before running dependency loop detection, > and so don't see it. Changing the type of THERMAL back to tristate makes > the C tools detect the same loop. > > Not sure if running dep. loop detection after simplification can be > called a bug. Fixing this nit unbreaks Kconfiglib on the kernel at > least. > > Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com> > --- Thanks, applied to drm-misc-next. Noralf.
Den 01.10.2019 12.58, skrev Noralf Trønnes: > > > Den 27.09.2019 19.42, skrev Ulf Magnusson: >> Commit 554b3529fe01 ("thermal/drivers/core: Remove the module Kconfig's >> option") changed the type of THERMAL from tristate to bool, so >> THERMAL || !THERMAL is now always y. Remove the redundant dependency. >> >> Discovered through Kconfiglib detecting a dependency loop. The C tools >> simplify the expression to y before running dependency loop detection, >> and so don't see it. Changing the type of THERMAL back to tristate makes >> the C tools detect the same loop. >> >> Not sure if running dep. loop detection after simplification can be >> called a bug. Fixing this nit unbreaks Kconfiglib on the kernel at >> least. >> >> Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com> >> --- > > Thanks, applied to drm-misc-next. > This has now been queued for the next -rc pull. Discussion: https://patchwork.freedesktop.org/patch/319826/ Noralf.
diff --git a/drivers/gpu/drm/tiny/Kconfig b/drivers/gpu/drm/tiny/Kconfig index 504763423d46..a46ac284dd5e 100644 --- a/drivers/gpu/drm/tiny/Kconfig +++ b/drivers/gpu/drm/tiny/Kconfig @@ -63,7 +63,6 @@ config TINYDRM_REPAPER depends on DRM && SPI select DRM_KMS_HELPER select DRM_KMS_CMA_HELPER - depends on THERMAL || !THERMAL help DRM driver for the following Pervasive Displays panels: 1.44" TFT EPD Panel (E1144CS021)
Commit 554b3529fe01 ("thermal/drivers/core: Remove the module Kconfig's option") changed the type of THERMAL from tristate to bool, so THERMAL || !THERMAL is now always y. Remove the redundant dependency. Discovered through Kconfiglib detecting a dependency loop. The C tools simplify the expression to y before running dependency loop detection, and so don't see it. Changing the type of THERMAL back to tristate makes the C tools detect the same loop. Not sure if running dep. loop detection after simplification can be called a bug. Fixing this nit unbreaks Kconfiglib on the kernel at least. Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com> --- drivers/gpu/drm/tiny/Kconfig | 1 - 1 file changed, 1 deletion(-)