diff mbox series

rt2x00: initialize last_reset

Message ID 20190926085433.1300-1-sgruszka@redhat.com (mailing list archive)
State Accepted
Commit c91a9cfe9f6d136172a52ff6e01b3f83ba850c19
Delegated to: Kalle Valo
Headers show
Series rt2x00: initialize last_reset | expand

Commit Message

Stanislaw Gruszka Sept. 26, 2019, 8:54 a.m. UTC
Initialize last_reset variable to INITIAL_JIFFIES, otherwise it is not
possible to test H/W reset for first 5 minutes of system run.

Fixes: e403fa31ed71 ("rt2x00: add restart hw")
Reported-and-tested-by: Jonathan Liu <net147@gmail.com>
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
---
 drivers/net/wireless/ralink/rt2x00/rt2x00debug.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Kalle Valo Oct. 1, 2019, 9:09 a.m. UTC | #1
Stanislaw Gruszka <sgruszka@redhat.com> wrote:

> Initialize last_reset variable to INITIAL_JIFFIES, otherwise it is not
> possible to test H/W reset for first 5 minutes of system run.
> 
> Fixes: e403fa31ed71 ("rt2x00: add restart hw")
> Reported-and-tested-by: Jonathan Liu <net147@gmail.com>
> Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>

I'll queue this to v5.4.
Kalle Valo Oct. 2, 2019, 4:37 a.m. UTC | #2
Stanislaw Gruszka <sgruszka@redhat.com> wrote:

> Initialize last_reset variable to INITIAL_JIFFIES, otherwise it is not
> possible to test H/W reset for first 5 minutes of system run.
> 
> Fixes: e403fa31ed71 ("rt2x00: add restart hw")
> Reported-and-tested-by: Jonathan Liu <net147@gmail.com>
> Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>

Patch applied to wireless-drivers.git, thanks.

c91a9cfe9f6d rt2x00: initialize last_reset
diff mbox series

Patch

diff --git a/drivers/net/wireless/ralink/rt2x00/rt2x00debug.c b/drivers/net/wireless/ralink/rt2x00/rt2x00debug.c
index 4d4e3888ef20..f2395309ec00 100644
--- a/drivers/net/wireless/ralink/rt2x00/rt2x00debug.c
+++ b/drivers/net/wireless/ralink/rt2x00/rt2x00debug.c
@@ -555,7 +555,7 @@  static ssize_t rt2x00debug_write_restart_hw(struct file *file,
 {
 	struct rt2x00debug_intf *intf =	file->private_data;
 	struct rt2x00_dev *rt2x00dev = intf->rt2x00dev;
-	static unsigned long last_reset;
+	static unsigned long last_reset = INITIAL_JIFFIES;
 
 	if (!rt2x00_has_cap_restart_hw(rt2x00dev))
 		return -EOPNOTSUPP;