| Message ID | 20191003155642.14909-10-hauke@hauke-m.de (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | backports: Update to kernel 5.4-rc1 | expand |
On Thu, 2019-10-03 at 17:56 +0200, Hauke Mehrtens wrote: > The ath9k owl driver uses pci_lock_rescan_remove() and > pci_unlock_rescan_remove() which was added in kernel 3.14, only compile > it on kernel >= 3.14. This confuses me a bit - isn't pci_stop_and_remove_bus_device() the more important part of the API? johannes -- To unsubscribe from this list: send the line "unsubscribe backports" in
On 10/4/19 10:55 AM, Johannes Berg wrote: > On Thu, 2019-10-03 at 17:56 +0200, Hauke Mehrtens wrote: >> The ath9k owl driver uses pci_lock_rescan_remove() and >> pci_unlock_rescan_remove() which was added in kernel 3.14, only compile >> it on kernel >= 3.14. > > This confuses me a bit - isn't pci_stop_and_remove_bus_device() the more > important part of the API? > > johannes > Hi Johannes, pci_stop_and_remove_bus_device() is available on kernel 3.10, but this code does a pci_uock_rescan_remove() and pci_unlock_rescan_remove() around it and this was added in kernel 3.14, see here: https://git.kernel.org/linus/9d16947b75831acd317ab9a53e0e94d160731d33 As this is currently only used for the ath9k owl loader and only causes problems on kernel < 3.14 I did not care much about this. Hauke
diff --git a/dependencies b/dependencies index 11470217..02d46ca3 100644 --- a/dependencies +++ b/dependencies @@ -52,6 +52,9 @@ ATH_TRACEPOINTS 3.1 # missigng add_hwgenerator_randomness() ATH9K_HWRNG 3.17 +# missing pci_lock_rescan_remove() +ATH9K_PCI_NO_EEPROM 3.14 + # This driver needs mmc_hw_reset() which was added in kernel version 3.2 MWIFIEX_SDIO 3.2
The ath9k owl driver uses pci_lock_rescan_remove() and pci_unlock_rescan_remove() which was added in kernel 3.14, only compile it on kernel >= 3.14. Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de> --- dependencies | 3 +++ 1 file changed, 3 insertions(+)