| Message ID | 20190921004928.24349-1-qing.huang@oracle.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | net/mlx5: Fixed a typo in a comment in esw_del_uc_addr() | expand |
I know this is not critical. Maybe someone can merge this or fix it with other commits? Thanks. On 9/20/19 5:49 PM, Qing Huang wrote: > Changed "managerss" to "managers". > > Fixes: a1b3839ac4a4 ("net/mlx5: E-Switch, Properly refer to the esw manager vport") > Signed-off-by: Qing Huang <qing.huang@oracle.com> > --- > drivers/net/ethernet/mellanox/mlx5/core/eswitch.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c b/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c > index 81e03e4..48642b8 100644 > --- a/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c > +++ b/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c > @@ -530,7 +530,7 @@ static int esw_del_uc_addr(struct mlx5_eswitch *esw, struct vport_addr *vaddr) > u16 vport = vaddr->vport; > int err = 0; > > - /* Skip mlx5_mpfs_del_mac for eswitch managerss, > + /* Skip mlx5_mpfs_del_mac for eswitch managers, > * it is already done by its netdev in mlx5e_execute_l2_action > */ > if (!vaddr->mpfs || esw->manager_vport == vport)
On Mon, Oct 07, 2019 at 05:38:55PM -0700, Qing Huang wrote: > I know this is not critical. Maybe someone can merge this or fix it with > other commits? Thanks. It is not "linux-rdma", but netdev. Your chances will be much higher if you use get_maintainer.pl and put relevant mailing lists together with maintainers in TO/CC parts of an email. Saeed will return from vacation and will take it to his net-next part. Thanks > > On 9/20/19 5:49 PM, Qing Huang wrote: > > Changed "managerss" to "managers". > > > > Fixes: a1b3839ac4a4 ("net/mlx5: E-Switch, Properly refer to the esw manager vport") > > Signed-off-by: Qing Huang <qing.huang@oracle.com> > > --- > > drivers/net/ethernet/mellanox/mlx5/core/eswitch.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c b/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c > > index 81e03e4..48642b8 100644 > > --- a/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c > > +++ b/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c > > @@ -530,7 +530,7 @@ static int esw_del_uc_addr(struct mlx5_eswitch *esw, struct vport_addr *vaddr) > > u16 vport = vaddr->vport; > > int err = 0; > > - /* Skip mlx5_mpfs_del_mac for eswitch managerss, > > + /* Skip mlx5_mpfs_del_mac for eswitch managers, > > * it is already done by its netdev in mlx5e_execute_l2_action > > */ > > if (!vaddr->mpfs || esw->manager_vport == vport)
On Tue, 2019-10-08 at 08:47 +0300, Leon Romanovsky wrote: > On Mon, Oct 07, 2019 at 05:38:55PM -0700, Qing Huang wrote: > > I know this is not critical. Maybe someone can merge this or fix it > > with > > other commits? Thanks. > > It is not "linux-rdma", but netdev. Your chances will be much higher > if > you use get_maintainer.pl and put relevant mailing lists together > with > maintainers in TO/CC parts of an email. > > Saeed will return from vacation and will take it to his net-next > part. > Applied to net-next-mlx5, please submit all mlx5 core (net) patches to netdev mailing list in the future to make it easier to find and review these patches. Thanks, Saeed. > Thanks > > > On 9/20/19 5:49 PM, Qing Huang wrote: > > > Changed "managerss" to "managers". > > > > > > Fixes: a1b3839ac4a4 ("net/mlx5: E-Switch, Properly refer to the > > > esw manager vport") > > > Signed-off-by: Qing Huang <qing.huang@oracle.com> > > > --- > > > drivers/net/ethernet/mellanox/mlx5/core/eswitch.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c > > > b/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c > > > index 81e03e4..48642b8 100644 > > > --- a/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c > > > +++ b/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c > > > @@ -530,7 +530,7 @@ static int esw_del_uc_addr(struct > > > mlx5_eswitch *esw, struct vport_addr *vaddr) > > > u16 vport = vaddr->vport; > > > int err = 0; > > > - /* Skip mlx5_mpfs_del_mac for eswitch managerss, > > > + /* Skip mlx5_mpfs_del_mac for eswitch managers, > > > * it is already done by its netdev in > > > mlx5e_execute_l2_action > > > */ > > > if (!vaddr->mpfs || esw->manager_vport == vport)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c b/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c index 81e03e4..48642b8 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c @@ -530,7 +530,7 @@ static int esw_del_uc_addr(struct mlx5_eswitch *esw, struct vport_addr *vaddr) u16 vport = vaddr->vport; int err = 0; - /* Skip mlx5_mpfs_del_mac for eswitch managerss, + /* Skip mlx5_mpfs_del_mac for eswitch managers, * it is already done by its netdev in mlx5e_execute_l2_action */ if (!vaddr->mpfs || esw->manager_vport == vport)
Changed "managerss" to "managers". Fixes: a1b3839ac4a4 ("net/mlx5: E-Switch, Properly refer to the esw manager vport") Signed-off-by: Qing Huang <qing.huang@oracle.com> --- drivers/net/ethernet/mellanox/mlx5/core/eswitch.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)