| Message ID | 20191010204606.15279-1-alexandre.belloni@bootlin.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | c23936fad79ea2bea749db19b8921bb4dc524905 |
| Headers | show |
| Series | net: lpc_eth: avoid resetting twice | expand |
From: Alexandre Belloni <alexandre.belloni@bootlin.com> Date: Thu, 10 Oct 2019 22:46:06 +0200 > __lpc_eth_shutdown is called after __lpc_eth_reset but it is already > calling __lpc_eth_reset. Avoid resetting the IP twice. > > Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Applied.
diff --git a/drivers/net/ethernet/nxp/lpc_eth.c b/drivers/net/ethernet/nxp/lpc_eth.c index fdcaf70151d4..e766a3e34d14 100644 --- a/drivers/net/ethernet/nxp/lpc_eth.c +++ b/drivers/net/ethernet/nxp/lpc_eth.c @@ -1364,9 +1364,6 @@ static int lpc_eth_drv_probe(struct platform_device *pdev) if (!is_valid_ether_addr(ndev->dev_addr)) eth_hw_addr_random(ndev); - /* Reset the ethernet controller */ - __lpc_eth_reset(pldat); - /* then shut everything down to save power */ __lpc_eth_shutdown(pldat);
__lpc_eth_shutdown is called after __lpc_eth_reset but it is already calling __lpc_eth_reset. Avoid resetting the IP twice. Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> --- drivers/net/ethernet/nxp/lpc_eth.c | 3 --- 1 file changed, 3 deletions(-)