| Message ID | 20191009142748.18005-6-hch@lst.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/8] xfs: pass the correct flag to xlog_write_iclog | expand |
On Wed, Oct 09, 2019 at 04:27:45PM +0200, Christoph Hellwig wrote: > XFSERRORDEBUG is never set and the code isn't all that useful, so remove > it. > > Signed-off-by: Christoph Hellwig <hch@lst.de> Looks ok, Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com> --D > --- > fs/xfs/xfs_log.c | 13 ------------- > 1 file changed, 13 deletions(-) > > diff --git a/fs/xfs/xfs_log.c b/fs/xfs/xfs_log.c > index 67a767d90ebf..7a429e5dc27c 100644 > --- a/fs/xfs/xfs_log.c > +++ b/fs/xfs/xfs_log.c > @@ -3996,19 +3996,6 @@ xfs_log_force_umount( > spin_unlock(&log->l_cilp->xc_push_lock); > xlog_state_do_callback(log, true, NULL); > > -#ifdef XFSERRORDEBUG > - { > - xlog_in_core_t *iclog; > - > - spin_lock(&log->l_icloglock); > - iclog = log->l_iclog; > - do { > - ASSERT(iclog->ic_callback == 0); > - iclog = iclog->ic_next; > - } while (iclog != log->l_iclog); > - spin_unlock(&log->l_icloglock); > - } > -#endif > /* return non-zero if log IOERROR transition had already happened */ > return retval; > } > -- > 2.20.1 >
On Wed, Oct 09, 2019 at 04:27:45PM +0200, Christoph Hellwig wrote: > XFSERRORDEBUG is never set and the code isn't all that useful, so remove > it. > > Signed-off-by: Christoph Hellwig <hch@lst.de> > --- Reviewed-by: Brian Foster <bfoster@redhat.com> > fs/xfs/xfs_log.c | 13 ------------- > 1 file changed, 13 deletions(-) > > diff --git a/fs/xfs/xfs_log.c b/fs/xfs/xfs_log.c > index 67a767d90ebf..7a429e5dc27c 100644 > --- a/fs/xfs/xfs_log.c > +++ b/fs/xfs/xfs_log.c > @@ -3996,19 +3996,6 @@ xfs_log_force_umount( > spin_unlock(&log->l_cilp->xc_push_lock); > xlog_state_do_callback(log, true, NULL); > > -#ifdef XFSERRORDEBUG > - { > - xlog_in_core_t *iclog; > - > - spin_lock(&log->l_icloglock); > - iclog = log->l_iclog; > - do { > - ASSERT(iclog->ic_callback == 0); > - iclog = iclog->ic_next; > - } while (iclog != log->l_iclog); > - spin_unlock(&log->l_icloglock); > - } > -#endif > /* return non-zero if log IOERROR transition had already happened */ > return retval; > } > -- > 2.20.1 >
diff --git a/fs/xfs/xfs_log.c b/fs/xfs/xfs_log.c index 67a767d90ebf..7a429e5dc27c 100644 --- a/fs/xfs/xfs_log.c +++ b/fs/xfs/xfs_log.c @@ -3996,19 +3996,6 @@ xfs_log_force_umount( spin_unlock(&log->l_cilp->xc_push_lock); xlog_state_do_callback(log, true, NULL); -#ifdef XFSERRORDEBUG - { - xlog_in_core_t *iclog; - - spin_lock(&log->l_icloglock); - iclog = log->l_iclog; - do { - ASSERT(iclog->ic_callback == 0); - iclog = iclog->ic_next; - } while (iclog != log->l_iclog); - spin_unlock(&log->l_icloglock); - } -#endif /* return non-zero if log IOERROR transition had already happened */ return retval; }
XFSERRORDEBUG is never set and the code isn't all that useful, so remove it. Signed-off-by: Christoph Hellwig <hch@lst.de> --- fs/xfs/xfs_log.c | 13 ------------- 1 file changed, 13 deletions(-)