| Message ID | 20191014212648.122549-1-briannorris@chromium.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 89dca86d29b46f2a5f38ea6476cfd441bd205d25 |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | rtw88: mark rtw_fw_hdr __packed | expand |
Brian Norris <briannorris@chromium.org> wrote: > The use of u8 and __le16 in this struct assumes that it's going to be > packed to byte alignment. C doesn't guarantee that, so we should mark > this __packed. > > Fixes: cc20a7139836 ("rtw88: use struct rtw_fw_hdr to access firmware header") > Cc: Ping-Ke Shih <pkshih@realtek.com> > Signed-off-by: Brian Norris <briannorris@chromium.org> Patch applied to wireless-drivers-next.git, thanks. 89dca86d29b4 rtw88: mark rtw_fw_hdr __packed
diff --git a/drivers/net/wireless/realtek/rtw88/fw.h b/drivers/net/wireless/realtek/rtw88/fw.h index 4f7999394235..73d1b9ca8efc 100644 --- a/drivers/net/wireless/realtek/rtw88/fw.h +++ b/drivers/net/wireless/realtek/rtw88/fw.h @@ -127,7 +127,7 @@ struct rtw_fw_hdr { __le32 emem_size; __le32 emem_addr; __le32 imem_addr; -}; +} __packed; /* C2H */ #define GET_CCX_REPORT_SEQNUM(c2h_payload) (c2h_payload[8] & 0xfc)
The use of u8 and __le16 in this struct assumes that it's going to be packed to byte alignment. C doesn't guarantee that, so we should mark this __packed. Fixes: cc20a7139836 ("rtw88: use struct rtw_fw_hdr to access firmware header") Cc: Ping-Ke Shih <pkshih@realtek.com> Signed-off-by: Brian Norris <briannorris@chromium.org> --- drivers/net/wireless/realtek/rtw88/fw.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)