| Message ID | 20191015140059.18660-1-ben.dooks@codethink.co.uk (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | PCI: sysfs: remove pci_bridge_groups and pcie_dev_groups | expand |
On Tue, Oct 15, 2019 at 03:00:59PM +0100, Ben Dooks wrote: > The pci_bridge_groups and pcie_dev_groups objects are > not exported and not used at-all, so remove them to > fix the following warnings from sparse: > > drivers/pci/pci-sysfs.c:1546:30: warning: symbol 'pci_bridge_groups' was not declared. Should it be static? > drivers/pci/pci-sysfs.c:1555:30: warning: symbol 'pcie_dev_groups' was not declared. Should it be static? > > Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> > --- > Cc: Bjorn Helgaas <bhelgaas@google.com> > Cc: linux-pci@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > --- > drivers/pci/pci-sysfs.c | 10 ---------- > 1 file changed, 10 deletions(-) > > diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c > index 793412954529..f7028cf3649a 100644 > --- a/drivers/pci/pci-sysfs.c > +++ b/drivers/pci/pci-sysfs.c > @@ -1543,20 +1543,10 @@ static const struct attribute_group pci_bridge_group = { > .attrs = pci_bridge_attrs, > }; > > -const struct attribute_group *pci_bridge_groups[] = { > - &pci_bridge_group, > - NULL, > -}; > - > static const struct attribute_group pcie_dev_group = { > .attrs = pcie_dev_attrs, > }; > > -const struct attribute_group *pcie_dev_groups[] = { > - &pcie_dev_group, > - NULL, > -}; > - > static const struct attribute_group pci_dev_hp_attr_group = { > .attrs = pci_dev_hp_attrs, > .is_visible = pci_dev_hp_attrs_are_visible, I find the sysfs attribute/group/groups stuff quite confusing, but aren't these now unused also? pci_bridge_group pcie_dev_group
On Tue, Oct 15, 2019 at 03:00:59PM +0100, Ben Dooks wrote: > The pci_bridge_groups and pcie_dev_groups objects are > not exported and not used at-all, so remove them to > fix the following warnings from sparse: > > drivers/pci/pci-sysfs.c:1546:30: warning: symbol 'pci_bridge_groups' was not declared. Should it be static? > drivers/pci/pci-sysfs.c:1555:30: warning: symbol 'pcie_dev_groups' was not declared. Should it be static? But now pci_bridge_group is unused, and if you remove that the attributes, etc..
On 16/10/2019 07:28, Christoph Hellwig wrote: > On Tue, Oct 15, 2019 at 03:00:59PM +0100, Ben Dooks wrote: >> The pci_bridge_groups and pcie_dev_groups objects are >> not exported and not used at-all, so remove them to >> fix the following warnings from sparse: >> >> drivers/pci/pci-sysfs.c:1546:30: warning: symbol 'pci_bridge_groups' was not declared. Should it be static? >> drivers/pci/pci-sysfs.c:1555:30: warning: symbol 'pcie_dev_groups' was not declared. Should it be static? > > But now pci_bridge_group is unused, and if you remove that the > attributes, etc.. Hmm, didn't get a warning for that. I'll go check.
On 16/10/2019 07:28, Christoph Hellwig wrote: > On Tue, Oct 15, 2019 at 03:00:59PM +0100, Ben Dooks wrote: >> The pci_bridge_groups and pcie_dev_groups objects are >> not exported and not used at-all, so remove them to >> fix the following warnings from sparse: >> >> drivers/pci/pci-sysfs.c:1546:30: warning: symbol 'pci_bridge_groups' was not declared. Should it be static? >> drivers/pci/pci-sysfs.c:1555:30: warning: symbol 'pcie_dev_groups' was not declared. Should it be static? > > But now pci_bridge_group is unused, and if you remove that the > attributes, etc.. Ok, thanks for spotting, i've removed those too. I've no idea why we're not getting compiler warnings for this.
diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c index 793412954529..f7028cf3649a 100644 --- a/drivers/pci/pci-sysfs.c +++ b/drivers/pci/pci-sysfs.c @@ -1543,20 +1543,10 @@ static const struct attribute_group pci_bridge_group = { .attrs = pci_bridge_attrs, }; -const struct attribute_group *pci_bridge_groups[] = { - &pci_bridge_group, - NULL, -}; - static const struct attribute_group pcie_dev_group = { .attrs = pcie_dev_attrs, }; -const struct attribute_group *pcie_dev_groups[] = { - &pcie_dev_group, - NULL, -}; - static const struct attribute_group pci_dev_hp_attr_group = { .attrs = pci_dev_hp_attrs, .is_visible = pci_dev_hp_attrs_are_visible,
The pci_bridge_groups and pcie_dev_groups objects are not exported and not used at-all, so remove them to fix the following warnings from sparse: drivers/pci/pci-sysfs.c:1546:30: warning: symbol 'pci_bridge_groups' was not declared. Should it be static? drivers/pci/pci-sysfs.c:1555:30: warning: symbol 'pcie_dev_groups' was not declared. Should it be static? Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> --- Cc: Bjorn Helgaas <bhelgaas@google.com> Cc: linux-pci@vger.kernel.org Cc: linux-kernel@vger.kernel.org --- drivers/pci/pci-sysfs.c | 10 ---------- 1 file changed, 10 deletions(-)