| Message ID | 20191017103436.5575-1-ben.dooks@codethink.co.uk (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | mmp: include common.h for mmp_timer_init | expand |
On Thu, 2019-10-17 at 11:34 +0100, Ben Dooks (Codethink) wrote: > The arch/arm/mach-mmp/time.c should include the > common.h header for the declaration of mmp_timer_init. > > This fixes the following sparse warning: > > arch/arm/mach-mmp/time.c:184:13: warning: symbol 'mmp_timer_init' was not declared. Should it be static? > > Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> Thank you. Reviewed-by: Lubomir Rintel <lkundrak@v3.sk> > --- > Cc: Lubomir Rintel <lkundrak@v3.sk> > Cc: linux-arm-kernel@lists.infradead.org > --- > arch/arm/mach-mmp/time.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/mach-mmp/time.c b/arch/arm/mach-mmp/time.c > index 483df32583be..0706d8f667de 100644 > --- a/arch/arm/mach-mmp/time.c > +++ b/arch/arm/mach-mmp/time.c > @@ -35,6 +35,7 @@ > #include "irqs.h" > #include "cputype.h" > #include "clock.h" > +#include "common.h" > > #define TIMERS_VIRT_BASE TIMERS1_VIRT_BASE >
diff --git a/arch/arm/mach-mmp/time.c b/arch/arm/mach-mmp/time.c index 483df32583be..0706d8f667de 100644 --- a/arch/arm/mach-mmp/time.c +++ b/arch/arm/mach-mmp/time.c @@ -35,6 +35,7 @@ #include "irqs.h" #include "cputype.h" #include "clock.h" +#include "common.h" #define TIMERS_VIRT_BASE TIMERS1_VIRT_BASE
The arch/arm/mach-mmp/time.c should include the common.h header for the declaration of mmp_timer_init. This fixes the following sparse warning: arch/arm/mach-mmp/time.c:184:13: warning: symbol 'mmp_timer_init' was not declared. Should it be static? Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> --- Cc: Lubomir Rintel <lkundrak@v3.sk> Cc: linux-arm-kernel@lists.infradead.org --- arch/arm/mach-mmp/time.c | 1 + 1 file changed, 1 insertion(+)