| Message ID | 20191007210730.7173-1-kamalheib1@gmail.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | b806c94ee44e53233b8ce6c92d9078d9781786a5 |
| Headers | show |
| Series | [for-rc] RDMA/qedr: Fix reported firmware version | expand |
> From: Kamal Heib <kamalheib1@gmail.com> > Sent: Tuesday, October 8, 2019 12:08 AM > > External Email > > ---------------------------------------------------------------------- > Remove spaces from the reported firmware version string. > Actual value: > $ cat /sys/class/infiniband/qedr0/fw_ver > 8. 37. 7. 0 > > Expected value: > $ cat /sys/class/infiniband/qedr0/fw_ver > 8.37.7.0 > > Fixes: ec72fce401c6 ("qedr: Add support for RoCE HW init") > Signed-off-by: Kamal Heib <kamalheib1@gmail.com> > --- > drivers/infiniband/hw/qedr/main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/infiniband/hw/qedr/main.c > b/drivers/infiniband/hw/qedr/main.c > index 5136b835e1ba..dc71b6e16a07 100644 > --- a/drivers/infiniband/hw/qedr/main.c > +++ b/drivers/infiniband/hw/qedr/main.c > @@ -76,7 +76,7 @@ static void qedr_get_dev_fw_str(struct ib_device > *ibdev, char *str) > struct qedr_dev *qedr = get_qedr_dev(ibdev); > u32 fw_ver = (u32)qedr->attr.fw_ver; > > - snprintf(str, IB_FW_VERSION_NAME_MAX, "%d. %d. %d. %d", > + snprintf(str, IB_FW_VERSION_NAME_MAX, "%d.%d.%d.%d", > (fw_ver >> 24) & 0xFF, (fw_ver >> 16) & 0xFF, > (fw_ver >> 8) & 0xFF, fw_ver & 0xFF); } > -- > 2.20.1 Thanks, Acked-by: Michal Kalderon <michal.kalderon@marvell.com>
On Tue, 2019-10-08 at 00:07 +0300, Kamal Heib wrote: > Remove spaces from the reported firmware version string. > Actual value: > $ cat /sys/class/infiniband/qedr0/fw_ver > 8. 37. 7. 0 > > Expected value: > $ cat /sys/class/infiniband/qedr0/fw_ver > 8.37.7.0 > > Fixes: ec72fce401c6 ("qedr: Add support for RoCE HW init") > Signed-off-by: Kamal Heib <kamalheib1@gmail.com> Thanks, applied to for-rc.
diff --git a/drivers/infiniband/hw/qedr/main.c b/drivers/infiniband/hw/qedr/main.c index 5136b835e1ba..dc71b6e16a07 100644 --- a/drivers/infiniband/hw/qedr/main.c +++ b/drivers/infiniband/hw/qedr/main.c @@ -76,7 +76,7 @@ static void qedr_get_dev_fw_str(struct ib_device *ibdev, char *str) struct qedr_dev *qedr = get_qedr_dev(ibdev); u32 fw_ver = (u32)qedr->attr.fw_ver; - snprintf(str, IB_FW_VERSION_NAME_MAX, "%d. %d. %d. %d", + snprintf(str, IB_FW_VERSION_NAME_MAX, "%d.%d.%d.%d", (fw_ver >> 24) & 0xFF, (fw_ver >> 16) & 0xFF, (fw_ver >> 8) & 0xFF, fw_ver & 0xFF); }
Remove spaces from the reported firmware version string. Actual value: $ cat /sys/class/infiniband/qedr0/fw_ver 8. 37. 7. 0 Expected value: $ cat /sys/class/infiniband/qedr0/fw_ver 8.37.7.0 Fixes: ec72fce401c6 ("qedr: Add support for RoCE HW init") Signed-off-by: Kamal Heib <kamalheib1@gmail.com> --- drivers/infiniband/hw/qedr/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)