| Message ID | 20191022153247.10286-1-ben.dooks@codethink.co.uk (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | xfs: add mising include of xfs_pnfs.h for missing declarations | expand |
On Tue, Oct 22, 2019 at 04:32:47PM +0100, Ben Dooks (Codethink) wrote: > The xfs_pnfs.c file is missing an include of xfs_pnfs.h to > add the prototypes of the functions it exports. Include this > file to fix the following sparse warnings: > > fs/xfs/xfs_pnfs.c:27:1: warning: symbol 'xfs_break_leased_layouts' was not declared. Should it be static? > fs/xfs/xfs_pnfs.c:52:1: warning: symbol 'xfs_fs_get_uuid' was not declared. Should it be static? > fs/xfs/xfs_pnfs.c:77:1: warning: symbol 'xfs_fs_map_blocks' was not declared. Should it be static? > fs/xfs/xfs_pnfs.c:226:1: warning: symbol 'xfs_fs_commit_blocks' was not declared. Should it be static? > > Signed-off-by: Ben Dooks (Codethink) <ben.dooks@codethink.co.uk> Looks ok, Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com> --D > --- > Cc: "Darrick J. Wong" <darrick.wong@oracle.com> > Cc: linux-xfs@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > --- > fs/xfs/xfs_pnfs.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/fs/xfs/xfs_pnfs.c b/fs/xfs/xfs_pnfs.c > index a339bd5fa260..b2f6f1e3d9c4 100644 > --- a/fs/xfs/xfs_pnfs.c > +++ b/fs/xfs/xfs_pnfs.c > @@ -12,6 +12,7 @@ > #include "xfs_trans.h" > #include "xfs_bmap.h" > #include "xfs_iomap.h" > +#include "xfs_pnfs.h" > > /* > * Ensure that we do not have any outstanding pNFS layouts that can be used by > -- > 2.23.0 >
diff --git a/fs/xfs/xfs_pnfs.c b/fs/xfs/xfs_pnfs.c index a339bd5fa260..b2f6f1e3d9c4 100644 --- a/fs/xfs/xfs_pnfs.c +++ b/fs/xfs/xfs_pnfs.c @@ -12,6 +12,7 @@ #include "xfs_trans.h" #include "xfs_bmap.h" #include "xfs_iomap.h" +#include "xfs_pnfs.h" /* * Ensure that we do not have any outstanding pNFS layouts that can be used by
The xfs_pnfs.c file is missing an include of xfs_pnfs.h to add the prototypes of the functions it exports. Include this file to fix the following sparse warnings: fs/xfs/xfs_pnfs.c:27:1: warning: symbol 'xfs_break_leased_layouts' was not declared. Should it be static? fs/xfs/xfs_pnfs.c:52:1: warning: symbol 'xfs_fs_get_uuid' was not declared. Should it be static? fs/xfs/xfs_pnfs.c:77:1: warning: symbol 'xfs_fs_map_blocks' was not declared. Should it be static? fs/xfs/xfs_pnfs.c:226:1: warning: symbol 'xfs_fs_commit_blocks' was not declared. Should it be static? Signed-off-by: Ben Dooks (Codethink) <ben.dooks@codethink.co.uk> --- Cc: "Darrick J. Wong" <darrick.wong@oracle.com> Cc: linux-xfs@vger.kernel.org Cc: linux-kernel@vger.kernel.org --- fs/xfs/xfs_pnfs.c | 1 + 1 file changed, 1 insertion(+)