mbox series

[0/1] Add support for setting MMIO PREF hotplug bridge size

Message ID PSXP216MB01832E0DD8892B52A3FA2589806B0@PSXP216MB0183.KORP216.PROD.OUTLOOK.COM (mailing list archive)
Headers show
Series Add support for setting MMIO PREF hotplug bridge size | expand

Message

Nicholas Johnson Oct. 23, 2019, 8:36 a.m. UTC
This patch adds support for two new kernel parameters. This patch has
been in the making for quite some time, and has changed several times
based on feedback.

I realised I was making the mistake of putting it as part of my
Thunderbolt patch series. Although the other patches in the series are
very important for my goal, I realised that they are just a heap of
patches that are not Thunderbolt-specific. The only thing that is
Thunderbolt-related is the intended use case.

I hope that posting this alone can ease the difficulty of reviewing it.

Nicholas Johnson (1):
  PCI: Add hp_mmio_size and hp_mmio_pref_size parameters

 .../admin-guide/kernel-parameters.txt         |  9 ++++++-
 drivers/pci/pci.c                             | 17 ++++++++++---
 drivers/pci/pci.h                             |  3 ++-
 drivers/pci/setup-bus.c                       | 25 +++++++++++--------
 4 files changed, 38 insertions(+), 16 deletions(-)

Comments

Mika Westerberg Oct. 23, 2019, 9:45 a.m. UTC | #1
On Wed, Oct 23, 2019 at 08:36:59AM +0000, Nicholas Johnson wrote:
> This patch adds support for two new kernel parameters. This patch has
> been in the making for quite some time, and has changed several times
> based on feedback.
> 
> I realised I was making the mistake of putting it as part of my
> Thunderbolt patch series. Although the other patches in the series are
> very important for my goal, I realised that they are just a heap of
> patches that are not Thunderbolt-specific. The only thing that is
> Thunderbolt-related is the intended use case.
> 
> I hope that posting this alone can ease the difficulty of reviewing it.
> 
> Nicholas Johnson (1):
>   PCI: Add hp_mmio_size and hp_mmio_pref_size parameters
> 
>  .../admin-guide/kernel-parameters.txt         |  9 ++++++-
>  drivers/pci/pci.c                             | 17 ++++++++++---
>  drivers/pci/pci.h                             |  3 ++-
>  drivers/pci/setup-bus.c                       | 25 +++++++++++--------
>  4 files changed, 38 insertions(+), 16 deletions(-)

If you want to add cover letter in the "normal way" so that threading is
preserved you can do something like 'git format-patch --cover-letter ...',
then edit the 0000-...patch and send it along with the other patches
using git send-email.
Nicholas Johnson Oct. 23, 2019, 10:43 a.m. UTC | #2
On Wed, Oct 23, 2019 at 12:45:22PM +0300, mika.westerberg@linux.intel.com wrote:
> On Wed, Oct 23, 2019 at 08:36:59AM +0000, Nicholas Johnson wrote:
> > This patch adds support for two new kernel parameters. This patch has
> > been in the making for quite some time, and has changed several times
> > based on feedback.
> > 
> > I realised I was making the mistake of putting it as part of my
> > Thunderbolt patch series. Although the other patches in the series are
> > very important for my goal, I realised that they are just a heap of
> > patches that are not Thunderbolt-specific. The only thing that is
> > Thunderbolt-related is the intended use case.
> > 
> > I hope that posting this alone can ease the difficulty of reviewing it.
> > 
> > Nicholas Johnson (1):
> >   PCI: Add hp_mmio_size and hp_mmio_pref_size parameters
> > 
> >  .../admin-guide/kernel-parameters.txt         |  9 ++++++-
> >  drivers/pci/pci.c                             | 17 ++++++++++---
> >  drivers/pci/pci.h                             |  3 ++-
> >  drivers/pci/setup-bus.c                       | 25 +++++++++++--------
> >  4 files changed, 38 insertions(+), 16 deletions(-)
> 
> If you want to add cover letter in the "normal way" so that threading is
> preserved you can do something like 'git format-patch --cover-letter ...',
> then edit the 0000-...patch and send it along with the other patches
I do everything above.

> using git send-email.
But I was told by Bjorn that I was sending emails with funny encoding 
which meant he had to manually apply the patches, which meant more work 
for him. I could not figure out how to make git send-email work with the 
correct encoding. I had to use mutt -H to fix the encoding, doing each 
email separately.

I have no idea why my git send-email is strange.