diff mbox series

mt7601u: use DEFINE_DEBUGFS_ATTRIBUTE to define debugfs fops

Message ID 1572422924-58878-1-git-send-email-zhongjiang@huawei.com (mailing list archive)
State Accepted
Commit 086ddf860650cfa3065d6698fae81335b1846cdb
Delegated to: Kalle Valo
Headers show
Series mt7601u: use DEFINE_DEBUGFS_ATTRIBUTE to define debugfs fops | expand

Commit Message

zhong jiang Oct. 30, 2019, 8:08 a.m. UTC
It is more clear to use DEFINE_DEBUGFS_ATTRIBUTE to define debugfs file
operation rather than DEFINE_SIMPLE_ATTRIBUTE.

Signed-off-by: zhong jiang <zhongjiang@huawei.com>
---
 drivers/net/wireless/mediatek/mt7601u/debugfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jakub Kicinski Oct. 30, 2019, 4:22 p.m. UTC | #1
On Wed, 30 Oct 2019 16:08:44 +0800, zhong jiang wrote:
> It is more clear to use DEFINE_DEBUGFS_ATTRIBUTE to define debugfs file
> operation rather than DEFINE_SIMPLE_ATTRIBUTE.
> 
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>

Acked-by: Jakub Kicinski <kubakici@wp.pl>
Kalle Valo Oct. 31, 2019, 8:10 a.m. UTC | #2
zhong jiang <zhongjiang@huawei.com> wrote:

> It is more clear to use DEFINE_DEBUGFS_ATTRIBUTE to define debugfs file
> operation rather than DEFINE_SIMPLE_ATTRIBUTE.
> 
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> Acked-by: Jakub Kicinski <kubakici@wp.pl>

Patch applied to wireless-drivers-next.git, thanks.

086ddf860650 mt7601u: use DEFINE_DEBUGFS_ATTRIBUTE to define debugfs fops
diff mbox series

Patch

diff --git a/drivers/net/wireless/mediatek/mt7601u/debugfs.c b/drivers/net/wireless/mediatek/mt7601u/debugfs.c
index 5e54983..300242b 100644
--- a/drivers/net/wireless/mediatek/mt7601u/debugfs.c
+++ b/drivers/net/wireless/mediatek/mt7601u/debugfs.c
@@ -27,7 +27,7 @@ 
 	return 0;
 }
 
-DEFINE_SIMPLE_ATTRIBUTE(fops_regval, mt76_reg_get, mt76_reg_set, "0x%08llx\n");
+DEFINE_DEBUGFS_ATTRIBUTE(fops_regval, mt76_reg_get, mt76_reg_set, "0x%08llx\n");
 
 static int
 mt7601u_ampdu_stat_read(struct seq_file *file, void *data)