| Message ID | 1572866050-29952-1-git-send-email-bharat@chelsio.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [rdma-core] cxgb4: free appropriate pointer in error case | expand |
On Mon, Nov 04, 2019 at 04:44:10PM +0530, Potnuri Bharat Teja wrote: > Fixes: 9b2d3af5735e ("Query device to get the max supported stags, qps, and cqs") > Signed-off-by: Potnuri Bharat Teja <bharat@chelsio.com> > --- We are not super-excited to see patches with empty commit message. Care to send PR to rdma-core? It will be easier for us to merge it. Thanks > providers/cxgb4/dev.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/providers/cxgb4/dev.c b/providers/cxgb4/dev.c > index 7f5955449ca1..4d02c7a91892 100644 > --- a/providers/cxgb4/dev.c > +++ b/providers/cxgb4/dev.c > @@ -203,9 +203,9 @@ err_free: > if (rhp->cqid2ptr) > free(rhp->cqid2ptr); > if (rhp->qpid2ptr) > - free(rhp->cqid2ptr); > + free(rhp->qpid2ptr); > if (rhp->mmid2ptr) > - free(rhp->cqid2ptr); > + free(rhp->mmid2ptr); > verbs_uninit_context(&context->ibv_ctx); > free(context); > return NULL; > -- > 2.3.9 >
On Monday, November 11/04/19, 2019 at 17:15:48 +0530, Leon Romanovsky wrote: > On Mon, Nov 04, 2019 at 04:44:10PM +0530, Potnuri Bharat Teja wrote: > > Fixes: 9b2d3af5735e ("Query device to get the max supported stags, qps, and cqs") > > Signed-off-by: Potnuri Bharat Teja <bharat@chelsio.com> > > --- > > We are not super-excited to see patches with empty commit message. My bad sent an older one instead. Shall resend the right one. > Care to send PR to rdma-core? It will be easier for us to merge it. This is how i do for rdma-core patches. first sent to mailing list and then send a PR. Is it the other way? > > Thanks > > > providers/cxgb4/dev.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/providers/cxgb4/dev.c b/providers/cxgb4/dev.c > > index 7f5955449ca1..4d02c7a91892 100644 > > --- a/providers/cxgb4/dev.c > > +++ b/providers/cxgb4/dev.c > > @@ -203,9 +203,9 @@ err_free: > > if (rhp->cqid2ptr) > > free(rhp->cqid2ptr); > > if (rhp->qpid2ptr) > > - free(rhp->cqid2ptr); > > + free(rhp->qpid2ptr); > > if (rhp->mmid2ptr) > > - free(rhp->cqid2ptr); > > + free(rhp->mmid2ptr); > > verbs_uninit_context(&context->ibv_ctx); > > free(context); > > return NULL; > > -- > > 2.3.9 > >
On Mon, Nov 04, 2019 at 05:51:50PM +0530, Potnuri Bharat Teja wrote: > On Monday, November 11/04/19, 2019 at 17:15:48 +0530, Leon Romanovsky wrote: > > On Mon, Nov 04, 2019 at 04:44:10PM +0530, Potnuri Bharat Teja wrote: > > > Fixes: 9b2d3af5735e ("Query device to get the max supported stags, qps, and cqs") > > > Signed-off-by: Potnuri Bharat Teja <bharat@chelsio.com> > > > --- > > > > We are not super-excited to see patches with empty commit message. > My bad sent an older one instead. Shall resend the right one. > > Care to send PR to rdma-core? It will be easier for us to merge it. > This is how i do for rdma-core patches. first sent to mailing list and then > send a PR. Is it the other way? You can skip sending patches to ML for trivial ones. Thanks
diff --git a/providers/cxgb4/dev.c b/providers/cxgb4/dev.c index 7f5955449ca1..4d02c7a91892 100644 --- a/providers/cxgb4/dev.c +++ b/providers/cxgb4/dev.c @@ -203,9 +203,9 @@ err_free: if (rhp->cqid2ptr) free(rhp->cqid2ptr); if (rhp->qpid2ptr) - free(rhp->cqid2ptr); + free(rhp->qpid2ptr); if (rhp->mmid2ptr) - free(rhp->cqid2ptr); + free(rhp->mmid2ptr); verbs_uninit_context(&context->ibv_ctx); free(context); return NULL;
Fixes: 9b2d3af5735e ("Query device to get the max supported stags, qps, and cqs") Signed-off-by: Potnuri Bharat Teja <bharat@chelsio.com> --- providers/cxgb4/dev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)