| Message ID | 591c5ca23fc0399ebd8a4bc2520bdabf07d9538c.1573008520.git.chunfeng.yun@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [01/28] usb: common: change usb_debug_root as static variable | expand |
On Wed, Nov 06, 2019 at 11:15:17AM +0800, Chunfeng Yun wrote: > The usb_debug_root is now a file-scope static variable, use > usb_debugfs_create_dir() to create directory under usb root > > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> > --- > drivers/media/common/siano/smsdvb-debugfs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/common/siano/smsdvb-debugfs.c b/drivers/media/common/siano/smsdvb-debugfs.c > index c95d4583498e..28c025e39a00 100644 > --- a/drivers/media/common/siano/smsdvb-debugfs.c > +++ b/drivers/media/common/siano/smsdvb-debugfs.c > @@ -514,7 +514,7 @@ void smsdvb_debugfs_register(void) > * node for sdio-based boards, but this may need some logic at sdio > * subsystem. > */ > - d = debugfs_create_dir("smsdvb", usb_debug_root); > + d = usb_debugfs_create_dir("smsdvb"); > if (IS_ERR_OR_NULL(d)) { This check is not needed. > pr_err("Couldn't create sysfs node for smsdvb\n"); This error is not correct no matter what you did here, so it needs to be removed too. thanks, greg k-h
On Wed, Nov 06, 2019 at 11:15:17AM +0800, Chunfeng Yun wrote: > The usb_debug_root is now a file-scope static variable, use > usb_debugfs_create_dir() to create directory under usb root > > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> > --- > drivers/media/common/siano/smsdvb-debugfs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/common/siano/smsdvb-debugfs.c b/drivers/media/common/siano/smsdvb-debugfs.c > index c95d4583498e..28c025e39a00 100644 > --- a/drivers/media/common/siano/smsdvb-debugfs.c > +++ b/drivers/media/common/siano/smsdvb-debugfs.c > @@ -514,7 +514,7 @@ void smsdvb_debugfs_register(void) > * node for sdio-based boards, but this may need some logic at sdio > * subsystem. > */ > - d = debugfs_create_dir("smsdvb", usb_debug_root); > + d = usb_debugfs_create_dir("smsdvb"); It is odd that a media driver is using the usb debugfs directory. Anyone know why that is? thanks, greg k-h
diff --git a/drivers/media/common/siano/smsdvb-debugfs.c b/drivers/media/common/siano/smsdvb-debugfs.c index c95d4583498e..28c025e39a00 100644 --- a/drivers/media/common/siano/smsdvb-debugfs.c +++ b/drivers/media/common/siano/smsdvb-debugfs.c @@ -514,7 +514,7 @@ void smsdvb_debugfs_register(void) * node for sdio-based boards, but this may need some logic at sdio * subsystem. */ - d = debugfs_create_dir("smsdvb", usb_debug_root); + d = usb_debugfs_create_dir("smsdvb"); if (IS_ERR_OR_NULL(d)) { pr_err("Couldn't create sysfs node for smsdvb\n"); return;
The usb_debug_root is now a file-scope static variable, use usb_debugfs_create_dir() to create directory under usb root Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> --- drivers/media/common/siano/smsdvb-debugfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)