| Message ID | PS2P216MB075530CB1B7B099AAF9F42D580780@PS2P216MB0755.KORP216.PROD.OUTLOOK.COM (mailing list archive) |
|---|---|
| Headers | show |
| Series | Fix bug resulting in double hpmemsize being assigned to MMIO window | expand |
On 2019-11-07 6:50 a.m., Nicholas Johnson wrote: > I have split this patch off my main series, as I realised that it does > not need to be part of that series. > > I have made some recent improvements to add assurance against it > breaking existing behaviour. Instead of returning the first resource of > the desired type regardless of it being assigned, now it goes through > all of the resources and returns only those of type that are not > assigned. Only then does it go through and return the first resource of > desired type that is assigned. If none are found then it returns NULL as > usual. > > I have made extensive changes to the patch notes, also. > > Logan Gunthorpe <logang@deltatee.com> has an alternative method of > fixing this same bug. Please also consider his patch and accept > whichever is best for Linux. All I care is that the bug be fixed. Oh, yes, I haven't had time to follow up on this. My patch is here[1]. It has a bit more info in the commit message and is a bit less intrusive. However, Nicholas's approach is more of a cleanup and may be a bit cleaner going forward. I also had another bug fix in that series I really need to find time to update and resend. I'll try to do it in the next cycle. Logan [1] https://lore.kernel.org/linux-pci/20190531171216.20532-2-logang@deltatee.com/
I have split this patch off my main series, as I realised that it does not need to be part of that series. I have made some recent improvements to add assurance against it breaking existing behaviour. Instead of returning the first resource of the desired type regardless of it being assigned, now it goes through all of the resources and returns only those of type that are not assigned. Only then does it go through and return the first resource of desired type that is assigned. If none are found then it returns NULL as usual. I have made extensive changes to the patch notes, also. Logan Gunthorpe <logang@deltatee.com> has an alternative method of fixing this same bug. Please also consider his patch and accept whichever is best for Linux. All I care is that the bug be fixed. Nicholas Johnson (1): PCI: Fix bug resulting in double hpmemsize being assigned to MMIO window drivers/pci/setup-bus.c | 34 +++++++++++++++++++++++----------- 1 file changed, 23 insertions(+), 11 deletions(-)