mbox series

[0/5] Fix -Wcast-function-type net drivers

Message ID 20191124094306.21297-1-tranmanphong@gmail.com (mailing list archive)
Headers show
Series Fix -Wcast-function-type net drivers | expand

Message

Phong Tran Nov. 24, 2019, 9:43 a.m. UTC 
This series is for fixing the compiler warning while enable
-Wcast-function-type.

Almost is incompatible callback prototype in using tasklet.
The void (*func)(unsigned long) instead of void (*func)(struct foo*).

Reported by: https://github.com/KSPP/linux/issues/20

Phong Tran (5):
  drivers: net: hso: Fix -Wcast-function-type
  drivers: net: usbnet: Fix -Wcast-function-type
  drivers: net: b43legacy: Fix -Wcast-function-type
  drivers: net: intel: Fix -Wcast-function-type
  drivers: net: realtek: Fix -Wcast-function-type

 drivers/net/usb/hso.c                          |  5 +++--
 drivers/net/usb/usbnet.c                       |  8 +++++++-
 drivers/net/wireless/broadcom/b43legacy/main.c |  5 +++--
 drivers/net/wireless/intel/ipw2x00/ipw2100.c   |  7 ++++---
 drivers/net/wireless/intel/ipw2x00/ipw2200.c   |  5 +++--
 drivers/net/wireless/intel/iwlegacy/3945-mac.c |  5 +++--
 drivers/net/wireless/intel/iwlegacy/4965-mac.c |  5 +++--
 drivers/net/wireless/realtek/rtlwifi/pci.c     | 10 ++++++----
 8 files changed, 32 insertions(+), 18 deletions(-)

Comments

Jakub Kicinski Nov. 24, 2019, 10:39 p.m. UTC | #1 
On Sun, 24 Nov 2019 16:43:01 +0700, Phong Tran wrote:
> This series is for fixing the compiler warning while enable
> -Wcast-function-type.
> 
> Almost is incompatible callback prototype in using tasklet.
> The void (*func)(unsigned long) instead of void (*func)(struct foo*).
> 
> Reported by: https://github.com/KSPP/linux/issues/20

Hi Tran, thanks for the patches. Could you split the series into two -
the wireless changes and the USB changes?

Those usually go via slightly different trees.
Phong Tran Nov. 25, 2019, 3:06 p.m. UTC | #2 
On 11/25/19 5:39 AM, Jakub Kicinski wrote:
> On Sun, 24 Nov 2019 16:43:01 +0700, Phong Tran wrote:
>> This series is for fixing the compiler warning while enable
>> -Wcast-function-type.
>>
>> Almost is incompatible callback prototype in using tasklet.
>> The void (*func)(unsigned long) instead of void (*func)(struct foo*).
>>
>> Reported by: https://github.com/KSPP/linux/issues/20
> 
> Hi Tran, thanks for the patches. Could you split the series into two -
> the wireless changes and the USB changes?
> 
> Those usually go via slightly different trees.
> 

Sent in different series:

[wireless]
https://lore.kernel.org/lkml/20191125150215.29263-1-tranmanphong@gmail.com/

[USB]
https://lore.kernel.org/linux-usb/20191125145443.29052-1-tranmanphong@gmail.com/

Regards,
Phong.
Jakub Kicinski Nov. 25, 2019, 5:04 p.m. UTC | #3 
On Mon, 25 Nov 2019 22:06:49 +0700, Phong Tran wrote:
> Sent in different series:
> 
> [wireless]
> https://lore.kernel.org/lkml/20191125150215.29263-1-tranmanphong@gmail.com/
> 
> [USB]
> https://lore.kernel.org/linux-usb/20191125145443.29052-1-tranmanphong@gmail.com/

Thank you!