[RFC,0/4] git-p4: python 3 compatability

Message

Yang Zhao Nov. 28, 2019, 1:28 a.m. UTC

This patchset the necessary changes to have git-p4 run under python 3.

I'm submitting this as an RFC as the changes are not exhaustive. I do not have
p4d available, and therefore cannot run the tests locally. I have made
best-effort attempts to test the changes against a repo I do have read access to.

Yang Zhao (4):
  git-p4: decode response from p4 to str for python3
  git-p4: properly encode/decode communication with git for python 3
  git-p4: open .gitp4-usercache.txt in text mode
  git-p4: use utf-8 encoding for file paths throughout

 git-p4.py | 58 +++++++++++++++++++++++++++++++++++++++----------------
 1 file changed, 41 insertions(+), 17 deletions(-)

Comments

Johannes Schindelin Nov. 28, 2019, 12:54 p.m. UTC | #1

Hi,

On Wed, 27 Nov 2019, Yang Zhao wrote:

> This patchset the necessary changes to have git-p4 run under python 3.
>
> I'm submitting this as an RFC as the changes are not exhaustive. I do not have
> p4d available, and therefore cannot run the tests locally. I have made
> best-effort attempts to test the changes against a repo I do have read access to.

How about opening a PR at https://github.com/git/git? This will run our
Travis and Azure Pipelines builds, and I am sure that you can add a
debug-only patch to force-use Python3 on the Perforce tests (and if I were
you, I would also restrict the run to those tests by editing `.travis.yml`
and `azure-pipelines.yml`, both of which files should be easy enough to
understand without additional documentation).

Ciao,
Johannes