| Message ID | 20191205040236.26066-1-lubaihua0331@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | xfs/191-input-validation:The "verion=1 -m crc=1" option is valid | expand |
On Thu, Dec 05, 2019 at 04:02:36AM +0000, Baihua Lu wrote: > The "version=1 -m crc=1" option is valid, so the test should be passed. # mkfs.xfs -l version=1 -m crc=1 /dev/sda1 V2 logs always enabled for CRC enabled filesystems Usage: mkfs.xfs /* blocksize */ [-b size=num] <other junk> That's a pass? <confused> --D > > Signed-off-by: Baihua Lu <lubaihua0331@gmail.com> > --- > tests/xfs/191-input-validation | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/xfs/191-input-validation b/tests/xfs/191-input-validation > index db427349..b5611c5b 100755 > --- a/tests/xfs/191-input-validation > +++ b/tests/xfs/191-input-validation > @@ -217,6 +217,7 @@ do_mkfs_pass -l lazy-count=1 -m crc=0 $SCRATCH_DEV > do_mkfs_pass -l version=1 -m crc=0 $SCRATCH_DEV > do_mkfs_pass -l version=2 -m crc=0 $SCRATCH_DEV > do_mkfs_pass -l version=2 $SCRATCH_DEV > +do_mkfs_pass -l version=1 -m crc=1 $SCRATCH_DEV > > # log section, should fail > do_mkfs_fail -l size=${fssize}b $SCRATCH_DEV > @@ -239,7 +240,6 @@ do_mkfs_fail -l internal=1,logdev=$fsimg $SCRATCH_DEV > do_mkfs_fail -l lazy-count=1garbage $SCRATCH_DEV > do_mkfs_fail -l lazy-count=2 $SCRATCH_DEV > do_mkfs_fail -l lazy-count=0 -m crc=1 $SCRATCH_DEV > -do_mkfs_fail -l version=1 -m crc=1 $SCRATCH_DEV > do_mkfs_fail -l version=0 $SCRATCH_DEV > > > -- > 2.17.1 >
diff --git a/tests/xfs/191-input-validation b/tests/xfs/191-input-validation index db427349..b5611c5b 100755 --- a/tests/xfs/191-input-validation +++ b/tests/xfs/191-input-validation @@ -217,6 +217,7 @@ do_mkfs_pass -l lazy-count=1 -m crc=0 $SCRATCH_DEV do_mkfs_pass -l version=1 -m crc=0 $SCRATCH_DEV do_mkfs_pass -l version=2 -m crc=0 $SCRATCH_DEV do_mkfs_pass -l version=2 $SCRATCH_DEV +do_mkfs_pass -l version=1 -m crc=1 $SCRATCH_DEV # log section, should fail do_mkfs_fail -l size=${fssize}b $SCRATCH_DEV @@ -239,7 +240,6 @@ do_mkfs_fail -l internal=1,logdev=$fsimg $SCRATCH_DEV do_mkfs_fail -l lazy-count=1garbage $SCRATCH_DEV do_mkfs_fail -l lazy-count=2 $SCRATCH_DEV do_mkfs_fail -l lazy-count=0 -m crc=1 $SCRATCH_DEV -do_mkfs_fail -l version=1 -m crc=1 $SCRATCH_DEV do_mkfs_fail -l version=0 $SCRATCH_DEV
The "version=1 -m crc=1" option is valid, so the test should be passed. Signed-off-by: Baihua Lu <lubaihua0331@gmail.com> --- tests/xfs/191-input-validation | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)