Message ID | 20191210020512.6088-1-digetx@gmail.com (mailing list archive) |
---|---|
State | Accepted, archived |
Headers | show |
Series | [v1] clk: tegra: Fix double-free in tegra_clk_init() | expand |
On Tue, Dec 10, 2019 at 05:05:12AM +0300, Dmitry Osipenko wrote: > It's unlikely to happen in practice ever, but makes static checkers happy. > > Fixes: 535f296d47de ("clk: tegra: Add suspend and resume support on Tegra210") > Reported-by: Stephen Boyd <sboyd@kernel.org> > Signed-off-by: Dmitry Osipenko <digetx@gmail.com> > --- > drivers/clk/tegra/clk.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Good catch: Acked-by: Thierry Reding <treding@nvidia.com>
Quoting Dmitry Osipenko (2019-12-09 18:05:12) > It's unlikely to happen in practice ever, but makes static checkers happy. > > Fixes: 535f296d47de ("clk: tegra: Add suspend and resume support on Tegra210") > Reported-by: Stephen Boyd <sboyd@kernel.org> > Signed-off-by: Dmitry Osipenko <digetx@gmail.com> > --- Applied to clk-fixes
diff --git a/drivers/clk/tegra/clk.c b/drivers/clk/tegra/clk.c index e6bd6d1ea012..f6cdce441cf7 100644 --- a/drivers/clk/tegra/clk.c +++ b/drivers/clk/tegra/clk.c @@ -231,8 +231,10 @@ struct clk ** __init tegra_clk_init(void __iomem *regs, int num, int banks) periph_banks = banks; clks = kcalloc(num, sizeof(struct clk *), GFP_KERNEL); - if (!clks) + if (!clks) { kfree(periph_clk_enb_refcnt); + return NULL; + } clk_num = num;
It's unlikely to happen in practice ever, but makes static checkers happy. Fixes: 535f296d47de ("clk: tegra: Add suspend and resume support on Tegra210") Reported-by: Stephen Boyd <sboyd@kernel.org> Signed-off-by: Dmitry Osipenko <digetx@gmail.com> --- drivers/clk/tegra/clk.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)