| Message ID | 20200101174836.5513-1-markus.theil@tu-ilmenau.de (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Johannes Berg |
| Headers | show |
| Series | iw: info: print missing extended feature flag information | expand |
Markus Theil <markus.theil@tu-ilmenau.de> writes: > Some extended feature flags were not considered before. > > Signed-off-by: Markus Theil <markus.theil@tu-ilmenau.de> > --- > info.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/info.c b/info.c > index 38362d8..0f24dae 100644 > --- a/info.c > +++ b/info.c > @@ -676,7 +676,17 @@ broken_combination: > ext_feat_print(tb, DFS_OFFLOAD, "DFS offload"); > ext_feat_print(tb, CONTROL_PORT_OVER_NL80211, > "control port over nl80211"); > + ext_feat_print(tb, ACK_SIGNAL_SUPPORT, > + "ack signal level support"); > ext_feat_print(tb, TXQS, "FQ-CoDel-enabled intermediate TXQs"); > + ext_feat_print(tb, SCAN_RANDOM_SN, > + "use random sequence numbers in scans"); > + ext_feat_print(tb, SCAN_MIN_PREQ_CONTENT, > + "use probe request with only rate IEs in scans"); > + ext_feat_print(tb, CAN_REPLACE_PTK0, > + "can safely replace PTK 0 when rekeying"); > + ext_feat_print(tb, ENABLE_FTM_RESPONDER, > + "enable FTM (Fine Time Measurement) responder"); > ext_feat_print(tb, AIRTIME_FAIRNESS, > "airtime fairness scheduling"); I would prefer to keep TXQS and AIRTIME_FAIRNESS next to each other. Also, while you're at it, could you please add the newly-added AQL feature? Something like ext_feat_print(tb, AIRTIME_FAIRNESS, "airtime fairness scheduling"); + ext_feat_print(tb, AQL, + "Airtime Queue Limits (AQL)"); -Toke
On 1/6/20 12:16 PM, Toke Høiland-Jørgensen wrote: > Markus Theil <markus.theil@tu-ilmenau.de> writes: > >> Some extended feature flags were not considered before. >> >> Signed-off-by: Markus Theil <markus.theil@tu-ilmenau.de> >> --- >> info.c | 10 ++++++++++ >> 1 file changed, 10 insertions(+) >> >> diff --git a/info.c b/info.c >> index 38362d8..0f24dae 100644 >> --- a/info.c >> +++ b/info.c >> @@ -676,7 +676,17 @@ broken_combination: >> ext_feat_print(tb, DFS_OFFLOAD, "DFS offload"); >> ext_feat_print(tb, CONTROL_PORT_OVER_NL80211, >> "control port over nl80211"); >> + ext_feat_print(tb, ACK_SIGNAL_SUPPORT, >> + "ack signal level support"); >> ext_feat_print(tb, TXQS, "FQ-CoDel-enabled intermediate TXQs"); >> + ext_feat_print(tb, SCAN_RANDOM_SN, >> + "use random sequence numbers in scans"); >> + ext_feat_print(tb, SCAN_MIN_PREQ_CONTENT, >> + "use probe request with only rate IEs in scans"); >> + ext_feat_print(tb, CAN_REPLACE_PTK0, >> + "can safely replace PTK 0 when rekeying"); >> + ext_feat_print(tb, ENABLE_FTM_RESPONDER, >> + "enable FTM (Fine Time Measurement) responder"); >> ext_feat_print(tb, AIRTIME_FAIRNESS, >> "airtime fairness scheduling"); > I would prefer to keep TXQS and AIRTIME_FAIRNESS next to each other. > > Also, while you're at it, could you please add the newly-added AQL > feature? Something like > > ext_feat_print(tb, AIRTIME_FAIRNESS, > "airtime fairness scheduling"); > + ext_feat_print(tb, AQL, > + "Airtime Queue Limits (AQL)"); I'm currently working on some other small patches and will include this and reorder the flags such that TXQS and AIRTIME_FAIRNESS will be next to each other. Thanks for the hint! Markus > > -Toke >
Markus Theil <markus.theil@tu-ilmenau.de> writes: > On 1/6/20 12:16 PM, Toke Høiland-Jørgensen wrote: >> Markus Theil <markus.theil@tu-ilmenau.de> writes: >> >>> Some extended feature flags were not considered before. >>> >>> Signed-off-by: Markus Theil <markus.theil@tu-ilmenau.de> >>> --- >>> info.c | 10 ++++++++++ >>> 1 file changed, 10 insertions(+) >>> >>> diff --git a/info.c b/info.c >>> index 38362d8..0f24dae 100644 >>> --- a/info.c >>> +++ b/info.c >>> @@ -676,7 +676,17 @@ broken_combination: >>> ext_feat_print(tb, DFS_OFFLOAD, "DFS offload"); >>> ext_feat_print(tb, CONTROL_PORT_OVER_NL80211, >>> "control port over nl80211"); >>> + ext_feat_print(tb, ACK_SIGNAL_SUPPORT, >>> + "ack signal level support"); >>> ext_feat_print(tb, TXQS, "FQ-CoDel-enabled intermediate TXQs"); >>> + ext_feat_print(tb, SCAN_RANDOM_SN, >>> + "use random sequence numbers in scans"); >>> + ext_feat_print(tb, SCAN_MIN_PREQ_CONTENT, >>> + "use probe request with only rate IEs in scans"); >>> + ext_feat_print(tb, CAN_REPLACE_PTK0, >>> + "can safely replace PTK 0 when rekeying"); >>> + ext_feat_print(tb, ENABLE_FTM_RESPONDER, >>> + "enable FTM (Fine Time Measurement) responder"); >>> ext_feat_print(tb, AIRTIME_FAIRNESS, >>> "airtime fairness scheduling"); >> I would prefer to keep TXQS and AIRTIME_FAIRNESS next to each other. >> >> Also, while you're at it, could you please add the newly-added AQL >> feature? Something like >> >> ext_feat_print(tb, AIRTIME_FAIRNESS, >> "airtime fairness scheduling"); >> + ext_feat_print(tb, AQL, >> + "Airtime Queue Limits (AQL)"); > I'm currently working on some other small patches and will include this > and reorder the flags such that TXQS and AIRTIME_FAIRNESS will be next > to each other. > Thanks for the hint! Great, thanks! :) -Toke
diff --git a/info.c b/info.c index 38362d8..0f24dae 100644 --- a/info.c +++ b/info.c @@ -676,7 +676,17 @@ broken_combination: ext_feat_print(tb, DFS_OFFLOAD, "DFS offload"); ext_feat_print(tb, CONTROL_PORT_OVER_NL80211, "control port over nl80211"); + ext_feat_print(tb, ACK_SIGNAL_SUPPORT, + "ack signal level support"); ext_feat_print(tb, TXQS, "FQ-CoDel-enabled intermediate TXQs"); + ext_feat_print(tb, SCAN_RANDOM_SN, + "use random sequence numbers in scans"); + ext_feat_print(tb, SCAN_MIN_PREQ_CONTENT, + "use probe request with only rate IEs in scans"); + ext_feat_print(tb, CAN_REPLACE_PTK0, + "can safely replace PTK 0 when rekeying"); + ext_feat_print(tb, ENABLE_FTM_RESPONDER, + "enable FTM (Fine Time Measurement) responder"); ext_feat_print(tb, AIRTIME_FAIRNESS, "airtime fairness scheduling"); ext_feat_print(tb, AP_PMKSA_CACHING,
Some extended feature flags were not considered before. Signed-off-by: Markus Theil <markus.theil@tu-ilmenau.de> --- info.c | 10 ++++++++++ 1 file changed, 10 insertions(+)