| Message ID | 1578656965-2993-1-git-send-email-alan.maguire@oracle.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [kunit] kunit: building kunit as a module breaks allmodconfig | expand |
Hi Alan, On 1/10/20 4:49 AM, Alan Maguire wrote: > kunit tests that do not support module build should depend > on KUNIT=y rather than just KUNIT in Kconfig, otherwise > they will trigger compilation errors for "make allmodconfig" > builds. > > Fixes: 9fe124bf1b77 ("kunit: allow kunit to be loaded as a module") > Signed-off-by: Alan Maguire <alan.maguire@oracle.com> > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> Thanks for fixing this quickly. For future reference, Signed-off-by should be last. I fixed it and applied the patch. thanks, -- Shuah
On Fri, Jan 10, 2020 at 1:39 PM Shuah Khan <skhan@linuxfoundation.org> wrote: > > Hi Alan, > > On 1/10/20 4:49 AM, Alan Maguire wrote: > > kunit tests that do not support module build should depend > > on KUNIT=y rather than just KUNIT in Kconfig, otherwise > > they will trigger compilation errors for "make allmodconfig" > > builds. > > > > Fixes: 9fe124bf1b77 ("kunit: allow kunit to be loaded as a module") > > Signed-off-by: Alan Maguire <alan.maguire@oracle.com> > > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> > > Thanks for fixing this quickly. For future reference, Signed-off-by > should be last. I fixed it and applied the patch. Thanks everyone for taking care of this so quickly in my absence! Cheers
diff --git a/drivers/base/Kconfig b/drivers/base/Kconfig index c3b3b5c..5f0bc74 100644 --- a/drivers/base/Kconfig +++ b/drivers/base/Kconfig @@ -150,7 +150,7 @@ config DEBUG_TEST_DRIVER_REMOVE config PM_QOS_KUNIT_TEST bool "KUnit Test for PM QoS features" - depends on KUNIT + depends on KUNIT=y config HMEM_REPORTING bool diff --git a/security/apparmor/Kconfig b/security/apparmor/Kconfig index d547930..0fe3368 100644 --- a/security/apparmor/Kconfig +++ b/security/apparmor/Kconfig @@ -71,7 +71,7 @@ config SECURITY_APPARMOR_DEBUG_MESSAGES config SECURITY_APPARMOR_KUNIT_TEST bool "Build KUnit tests for policy_unpack.c" - depends on KUNIT && SECURITY_APPARMOR + depends on KUNIT=y && SECURITY_APPARMOR help This builds the AppArmor KUnit tests.
kunit tests that do not support module build should depend on KUNIT=y rather than just KUNIT in Kconfig, otherwise they will trigger compilation errors for "make allmodconfig" builds. Fixes: 9fe124bf1b77 ("kunit: allow kunit to be loaded as a module") Signed-off-by: Alan Maguire <alan.maguire@oracle.com> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> --- drivers/base/Kconfig | 2 +- security/apparmor/Kconfig | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)