Message ID | 20200115082447.19520-1-namjae.jeon@samsung.com (mailing list archive) |
---|---|
Headers | show |
Series | add the latest exfat driver | expand |
Hello! I have reviewed all changes in time when v10 has been preparing.
There is just a small issue with description of EXFAT_DEFAULT_IOCHARSET
option (see email). Otherwise it looks good you can add my Reviewed-by
on whole patch series.
Reviewed-by: Pali Rohár <pali.rohar@gmail.com>
Next steps for future:
* De-duplicate cache code between fat and exfat. Currently fs/exfat
cache code is heavily copy-paste of fs/fat cache code.
* De-duplicate UTF-16 functions. Currently fs/exfat has e.g. helper
functions for surrogate pairs copy-paste from fs/nls.
* Unify EXFAT_DEFAULT_IOCHARSET and FAT_DEFAULT_IOCHARSET. Or maybe
unify it with other filesystems too.
* After applying this patch series, remote staging exfat implementation.
2020-01-15 18:47 GMT+09:00, Pali Rohár <pali.rohar@gmail.com>: > Hello! I have reviewed all changes in time when v10 has been preparing. > > There is just a small issue with description of EXFAT_DEFAULT_IOCHARSET > option (see email). Otherwise it looks good you can add my Reviewed-by > on whole patch series. > > Reviewed-by: Pali Rohár <pali.rohar@gmail.com> Thanks for your review and help. I will add your reviewed-by tag on next version. > > Next steps for future: > > * De-duplicate cache code between fat and exfat. Currently fs/exfat > cache code is heavily copy-paste of fs/fat cache code. > > * De-duplicate UTF-16 functions. Currently fs/exfat has e.g. helper > functions for surrogate pairs copy-paste from fs/nls. > > * Unify EXFAT_DEFAULT_IOCHARSET and FAT_DEFAULT_IOCHARSET. Or maybe > unify it with other filesystems too. > > * After applying this patch series, remote staging exfat implementation. Yep, I will check them. > > -- > Pali Rohár > pali.rohar@gmail.com >
On Wed, Jan 15, 2020 at 10:47:32AM +0100, Pali Rohár wrote: > Next steps for future: > > * De-duplicate cache code between fat and exfat. Currently fs/exfat > cache code is heavily copy-paste of fs/fat cache code. As said before I don't think this should be a merge blocker. I actually see this more of an experiment as the sharing might make things worse. But at least it is worth giving it a try. > * De-duplicate UTF-16 functions. Currently fs/exfat has e.g. helper > functions for surrogate pairs copy-paste from fs/nls. If you looked into that can you post a list of suspected duplicates? > > * Unify EXFAT_DEFAULT_IOCHARSET and FAT_DEFAULT_IOCHARSET. Or maybe > unify it with other filesystems too. For the initial merge I think they should be kept separate, as referencing other file systems Kconfig variable is confusing. Investingating if we could a single common one sounds like a good idea, though. > * After applying this patch series, remote staging exfat implementation. I think Greg wants to do that separately. I still hope we can do that in the same merge window, though.
On Thursday 16 January 2020 11:51:08 Christoph Hellwig wrote: > On Wed, Jan 15, 2020 at 10:47:32AM +0100, Pali Rohár wrote: > > Next steps for future: I mean all points to be next future steps after merging. Not something for this patch series. Sorry for a confusion.
On Thu, Jan 16, 2020 at 11:51:08AM +0100, Christoph Hellwig wrote: > > * After applying this patch series, remote staging exfat implementation. > > I think Greg wants to do that separately. I still hope we can do that > in the same merge window, though. I will be glad to do it in the same merge window, just let me know when this gets accepted and I'll drop the staging version. thanks, greg k-h