| Message ID | b0b0c6db-7215-bb31-a1eb-722d13c72cdc@suse.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Arm/p2m: fix build after ea22bcd030da and 2aa977eb6baa | expand |
On 1/24/20 8:51 AM, Jan Beulich wrote: > Each of these commits introduced a function prototype referencing a > structure which hadn't at least been forward declared. Add such > declarations. > > Signed-off-by: Jan Beulich <jbeulich@suse.com> Acked-by: George Dunlap <george.dunlap@citrix.com> I wouldn't object if you decided to check these in immediately, given that it's a simple fix which un-breaks the build.
On 24.01.2020 11:05, George Dunlap wrote: > On 1/24/20 8:51 AM, Jan Beulich wrote: >> Each of these commits introduced a function prototype referencing a >> structure which hadn't at least been forward declared. Add such >> declarations. >> >> Signed-off-by: Jan Beulich <jbeulich@suse.com> > > Acked-by: George Dunlap <george.dunlap@citrix.com> Thanks. > I wouldn't object if you decided to check these in immediately, given > that it's a simple fix which un-breaks the build. Done. Jan
On Fri, Jan 24, 2020 at 5:50 AM Jan Beulich <jbeulich@suse.com> wrote: > > On 24.01.2020 11:05, George Dunlap wrote: > > On 1/24/20 8:51 AM, Jan Beulich wrote: > >> Each of these commits introduced a function prototype referencing a > >> structure which hadn't at least been forward declared. Add such > >> declarations. > >> > >> Signed-off-by: Jan Beulich <jbeulich@suse.com> > > > > Acked-by: George Dunlap <george.dunlap@citrix.com> > > Thanks. > > > I wouldn't object if you decided to check these in immediately, given > > that it's a simple fix which un-breaks the build. > > Done. Thanks for the fast fix. I sent a follow up patch that relocates the VE functions to x86. These really should not have been added to the common header to begin with. Tamas
--- a/xen/include/xen/mem_access.h +++ b/xen/include/xen/mem_access.h @@ -58,6 +58,7 @@ typedef enum { /* NOTE: Assumed to be only 4 bits right now on x86. */ } p2m_access_t; +struct p2m_domain; bool xenmem_access_to_p2m_access(const struct p2m_domain *p2m, xenmem_access_t xaccess, p2m_access_t *paccess); @@ -79,6 +80,7 @@ long p2m_set_mem_access_multi(struct dom int p2m_set_suppress_ve(struct domain *d, gfn_t gfn, bool suppress_ve, unsigned int altp2m_idx); +struct xen_hvm_altp2m_suppress_ve_multi; int p2m_set_suppress_ve_multi(struct domain *d, struct xen_hvm_altp2m_suppress_ve_multi *suppress_ve);
Each of these commits introduced a function prototype referencing a structure which hadn't at least been forward declared. Add such declarations. Signed-off-by: Jan Beulich <jbeulich@suse.com>