| Message ID | de42cdd5c5d2c46978c15cd2f27b49fa144ae6a7.1576606020.git.hns@goldelico.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | wl1251: remove ti,power-gpio for sdio mode | expand |
On Tue, 17 Dec 2019 19:06:59 +0100, "H. Nikolaus Schaller" wrote: > It is now only useful for SPI interface. > Power control of SDIO mode is done through mmc core. > > Suggested by: Ulf Hansson <ulf.hansson@linaro.org> > Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com> > --- > Documentation/devicetree/bindings/net/wireless/ti,wl1251.txt | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > Please add Acked-by/Reviewed-by tags when posting new versions. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for acks received on the version they apply. If a tag was not added on purpose, please state why and what changed.
> Am 18.12.2019 um 03:44 schrieb Rob Herring <robh@kernel.org>: > > On Tue, 17 Dec 2019 19:06:59 +0100, "H. Nikolaus Schaller" wrote: >> It is now only useful for SPI interface. >> Power control of SDIO mode is done through mmc core. >> >> Suggested by: Ulf Hansson <ulf.hansson@linaro.org> >> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com> >> --- >> Documentation/devicetree/bindings/net/wireless/ti,wl1251.txt | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> > > Please add Acked-by/Reviewed-by tags when posting new versions. However, > there's no need to repost patches *only* to add the tags. The upstream > maintainer will do that for acks received on the version they apply. > > If a tag was not added on purpose, please state why and what changed. Sorry, I just forgot to add. There was no change.
"H. Nikolaus Schaller" <hns@goldelico.com> wrote: > It is now only useful for SPI interface. > Power control of SDIO mode is done through mmc core. > > Suggested by: Ulf Hansson <ulf.hansson@linaro.org> > Acked-by: Rob Herring <robh@kernel.org> > Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com> Failed to apply to wireless-drivers-next, please rebase and resend. fatal: sha1 information is lacking or useless (drivers/net/wireless/ti/wl1251/sdio.c). error: could not build fake ancestor Applying: wl1251: remove ti,power-gpio for SDIO mode Patch failed at 0001 wl1251: remove ti,power-gpio for SDIO mode The copy of the patch that failed is found in: .git/rebase-apply/patch 2 patches set to Changes Requested. 11298403 [PATCH v2 1/2] DTS: bindings: wl1251: mark ti,power-gpio as optional 11298399 [v2,2/2] wl1251: remove ti,power-gpio for SDIO mode
Hi, > Am 26.01.2020 um 16:31 schrieb Kalle Valo <kvalo@codeaurora.org>: > > "H. Nikolaus Schaller" <hns@goldelico.com> wrote: > >> It is now only useful for SPI interface. >> Power control of SDIO mode is done through mmc core. >> >> Suggested by: Ulf Hansson <ulf.hansson@linaro.org> >> Acked-by: Rob Herring <robh@kernel.org> >> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com> > > Failed to apply to wireless-drivers-next, please rebase and resend. On which commit and/or tree do you want to apply it? > fatal: sha1 information is lacking or useless (drivers/net/wireless/ti/wl1251/sdio.c). > error: could not build fake ancestor > Applying: wl1251: remove ti,power-gpio for SDIO mode > Patch failed at 0001 wl1251: remove ti,power-gpio for SDIO mode > The copy of the patch that failed is found in: .git/rebase-apply/patch > > 2 patches set to Changes Requested. > > 11298403 [PATCH v2 1/2] DTS: bindings: wl1251: mark ti,power-gpio as optional > 11298399 [v2,2/2] wl1251: remove ti,power-gpio for SDIO mode > > -- > https://patchwork.kernel.org/patch/11298403/ > > https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches BR and thanks, Nikolaus Schaller
"H. Nikolaus Schaller" <hns@goldelico.com> writes: > Hi, > >> Am 26.01.2020 um 16:31 schrieb Kalle Valo <kvalo@codeaurora.org>: >> >> "H. Nikolaus Schaller" <hns@goldelico.com> wrote: >> >>> It is now only useful for SPI interface. >>> Power control of SDIO mode is done through mmc core. >>> >>> Suggested by: Ulf Hansson <ulf.hansson@linaro.org> >>> Acked-by: Rob Herring <robh@kernel.org> >>> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com> >> >> Failed to apply to wireless-drivers-next, please rebase and resend. > > On which commit and/or tree do you want to apply it? I said it above, wireless-drivers-next: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git/
Hi Kalle, > Am 26.01.2020 um 17:16 schrieb Kalle Valo <kvalo@codeaurora.org>: > > "H. Nikolaus Schaller" <hns@goldelico.com> writes: > >> Hi, >> >>> Am 26.01.2020 um 16:31 schrieb Kalle Valo <kvalo@codeaurora.org>: >>> >>> "H. Nikolaus Schaller" <hns@goldelico.com> wrote: >>> >>>> It is now only useful for SPI interface. >>>> Power control of SDIO mode is done through mmc core. >>>> >>>> Suggested by: Ulf Hansson <ulf.hansson@linaro.org> >>>> Acked-by: Rob Herring <robh@kernel.org> >>>> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com> >>> >>> Failed to apply to wireless-drivers-next, please rebase and resend. >> >> On which commit and/or tree do you want to apply it? > > I said it above, wireless-drivers-next: > > https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git/ Ah, sorry. I did overlook it. I could easily cherry pick it so I think that the guard lines of the original submission did not match. v3 (rebased on tag wireless-drivers-next-2020-01-26) coming immediately. BR and thanks, Nikolaus
diff --git a/Documentation/devicetree/bindings/net/wireless/ti,wl1251.txt b/Documentation/devicetree/bindings/net/wireless/ti,wl1251.txt index f38950560982..88fd28d15eac 100644 --- a/Documentation/devicetree/bindings/net/wireless/ti,wl1251.txt +++ b/Documentation/devicetree/bindings/net/wireless/ti,wl1251.txt @@ -9,11 +9,12 @@ Required properties: - spi-max-frequency : Maximum SPI clocking speed of device in Hz - interrupts : Should contain interrupt line - vio-supply : phandle to regulator providing VIO -- ti,power-gpio : GPIO connected to chip's PMEN pin Optional properties: - ti,wl1251-has-eeprom : boolean, the wl1251 has an eeprom connected, which provides configuration data (calibration, MAC, ...) +- ti,power-gpio : GPIO connected to chip's PMEN pin if operated in + SPI mode - Please consult Documentation/devicetree/bindings/spi/spi-bus.txt for optional SPI connection related properties,
It is now only useful for SPI interface. Power control of SDIO mode is done through mmc core. Suggested by: Ulf Hansson <ulf.hansson@linaro.org> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com> --- Documentation/devicetree/bindings/net/wireless/ti,wl1251.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)