| Message ID | cee34bac9d6041784a92c5fdbf667c367dc7f968.1580874252.git.ryder.lee@mediatek.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Felix Fietkau |
| Headers | show |
| Series | mt76: mt7615: fix wrong length in strncmp | expand |
On 2020-02-05 04:46, Ryder Lee wrote: > Fix it to proper length. > > Signed-off-by: Ryder Lee <ryder.lee@mediatek.com> > --- > drivers/net/wireless/mediatek/mt76/mt7615/mcu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/mcu.c b/drivers/net/wireless/mediatek/mt76/mt7615/mcu.c > index 6639f9291721..fbda56342d11 100644 > --- a/drivers/net/wireless/mediatek/mt76/mt7615/mcu.c > +++ b/drivers/net/wireless/mediatek/mt76/mt7615/mcu.c > @@ -491,7 +491,7 @@ static int mt7615_load_ram(struct mt7615_dev *dev) > goto out; > } > > - if (!strncmp(hdr->fw_ver, "2.0", 6)) > + if (!strncmp(hdr->fw_ver, "2.0", 3)) Do you plan on allowing more characters after the 2.0 and still match? If not, maybe we should just use sizeof(hdr->fw_ver) as max len. - Felix
diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/mcu.c b/drivers/net/wireless/mediatek/mt76/mt7615/mcu.c index 6639f9291721..fbda56342d11 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7615/mcu.c +++ b/drivers/net/wireless/mediatek/mt76/mt7615/mcu.c @@ -491,7 +491,7 @@ static int mt7615_load_ram(struct mt7615_dev *dev) goto out; } - if (!strncmp(hdr->fw_ver, "2.0", 6)) + if (!strncmp(hdr->fw_ver, "2.0", 3)) dev->fw_ver = MT7615_FIRMWARE_V2; else dev->fw_ver = MT7615_FIRMWARE_V1;
Fix it to proper length. Signed-off-by: Ryder Lee <ryder.lee@mediatek.com> --- drivers/net/wireless/mediatek/mt76/mt7615/mcu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)