mbox series

[v4,0/7] thermal: tsens: Handle critical interrupts

Message ID cover.1580390127.git.amit.kucheria@linaro.org (mailing list archive)
Headers show
Series thermal: tsens: Handle critical interrupts | expand

Message

Amit Kucheria Jan. 30, 2020, 1:27 p.m. UTC
TSENS IP v2.x supports critical interrupts and v2.3+ adds watchdog support
in case the FSM is stuck. Enable support in the driver.

This series was generated on top of linux-next from 20200130 to integrate
some patches that that are queued currently.

Changes from v3:
- Remove the DTS changes that are already queued
- Fix review comments by Bjorn
- Fixup patch description to clarify that we don't use TSENS critical
  interrupts in Linux, but need it for the watchdog support that uses the
  same HW irq line.
- Separate kernel-doc fixes into a separate patch.

Changes from v2:
- Handle old DTBs w/o critical irq in the same way as fix sent for 5.5

Changes from v1:
- Make tsens_features non-const to allow run time detection of features
- Pass tsens_sensor around as a const
- Fix a bug to release dev pointer in success path
- Address review comments from Bjorn and Stephen (thanks for the review)
- Add msm8998 and msm8996 DTSI changes for critical interrupts



Amit Kucheria (7):
  drivers: thermal: tsens: Pass around struct tsens_sensor as a constant
  drivers: thermal: tsens: use simpler variables
  drivers: thermal: tsens: Release device in success path
  drivers: thermal: tsens: Add critical interrupt support
  drivers: thermal: tsens: Add watchdog support
  drivers: thermal: tsens: kernel-doc fixup
  drivers: thermal: tsens: Remove unnecessary irq flag

 drivers/thermal/qcom/tsens-8960.c   |   2 +-
 drivers/thermal/qcom/tsens-common.c | 191 ++++++++++++++++++++++++----
 drivers/thermal/qcom/tsens-v2.c     |  18 ++-
 drivers/thermal/qcom/tsens.c        |  26 +++-
 drivers/thermal/qcom/tsens.h        |  94 +++++++++++++-
 5 files changed, 300 insertions(+), 31 deletions(-)

Comments

Daniel Lezcano Feb. 17, 2020, 3:25 p.m. UTC | #1
Hi Amit,

can you respin the series against v5.6-rc2?

Thanks

  -- Daniel


On 30/01/2020 14:27, Amit Kucheria wrote:
> TSENS IP v2.x supports critical interrupts and v2.3+ adds watchdog support
> in case the FSM is stuck. Enable support in the driver.
> 
> This series was generated on top of linux-next from 20200130 to integrate
> some patches that that are queued currently.
> 
> Changes from v3:
> - Remove the DTS changes that are already queued
> - Fix review comments by Bjorn
> - Fixup patch description to clarify that we don't use TSENS critical
>   interrupts in Linux, but need it for the watchdog support that uses the
>   same HW irq line.
> - Separate kernel-doc fixes into a separate patch.
> 
> Changes from v2:
> - Handle old DTBs w/o critical irq in the same way as fix sent for 5.5
> 
> Changes from v1:
> - Make tsens_features non-const to allow run time detection of features
> - Pass tsens_sensor around as a const
> - Fix a bug to release dev pointer in success path
> - Address review comments from Bjorn and Stephen (thanks for the review)
> - Add msm8998 and msm8996 DTSI changes for critical interrupts
> 
> 
> 
> Amit Kucheria (7):
>   drivers: thermal: tsens: Pass around struct tsens_sensor as a constant
>   drivers: thermal: tsens: use simpler variables
>   drivers: thermal: tsens: Release device in success path
>   drivers: thermal: tsens: Add critical interrupt support
>   drivers: thermal: tsens: Add watchdog support
>   drivers: thermal: tsens: kernel-doc fixup
>   drivers: thermal: tsens: Remove unnecessary irq flag
> 
>  drivers/thermal/qcom/tsens-8960.c   |   2 +-
>  drivers/thermal/qcom/tsens-common.c | 191 ++++++++++++++++++++++++----
>  drivers/thermal/qcom/tsens-v2.c     |  18 ++-
>  drivers/thermal/qcom/tsens.c        |  26 +++-
>  drivers/thermal/qcom/tsens.h        |  94 +++++++++++++-
>  5 files changed, 300 insertions(+), 31 deletions(-)
>
Amit Kucheria Feb. 18, 2020, 5:36 a.m. UTC | #2
Hi Daniel,

OK. I will address one last comment as part of the rebase.

Regards,
Amit

On Mon, Feb 17, 2020 at 8:55 PM Daniel Lezcano
<daniel.lezcano@linaro.org> wrote:
>
>
> Hi Amit,
>
> can you respin the series against v5.6-rc2?
>
> Thanks
>
>   -- Daniel
>
>
> On 30/01/2020 14:27, Amit Kucheria wrote:
> > TSENS IP v2.x supports critical interrupts and v2.3+ adds watchdog support
> > in case the FSM is stuck. Enable support in the driver.
> >
> > This series was generated on top of linux-next from 20200130 to integrate
> > some patches that that are queued currently.
> >
> > Changes from v3:
> > - Remove the DTS changes that are already queued
> > - Fix review comments by Bjorn
> > - Fixup patch description to clarify that we don't use TSENS critical
> >   interrupts in Linux, but need it for the watchdog support that uses the
> >   same HW irq line.
> > - Separate kernel-doc fixes into a separate patch.
> >
> > Changes from v2:
> > - Handle old DTBs w/o critical irq in the same way as fix sent for 5.5
> >
> > Changes from v1:
> > - Make tsens_features non-const to allow run time detection of features
> > - Pass tsens_sensor around as a const
> > - Fix a bug to release dev pointer in success path
> > - Address review comments from Bjorn and Stephen (thanks for the review)
> > - Add msm8998 and msm8996 DTSI changes for critical interrupts
> >
> >
> >
> > Amit Kucheria (7):
> >   drivers: thermal: tsens: Pass around struct tsens_sensor as a constant
> >   drivers: thermal: tsens: use simpler variables
> >   drivers: thermal: tsens: Release device in success path
> >   drivers: thermal: tsens: Add critical interrupt support
> >   drivers: thermal: tsens: Add watchdog support
> >   drivers: thermal: tsens: kernel-doc fixup
> >   drivers: thermal: tsens: Remove unnecessary irq flag
> >
> >  drivers/thermal/qcom/tsens-8960.c   |   2 +-
> >  drivers/thermal/qcom/tsens-common.c | 191 ++++++++++++++++++++++++----
> >  drivers/thermal/qcom/tsens-v2.c     |  18 ++-
> >  drivers/thermal/qcom/tsens.c        |  26 +++-
> >  drivers/thermal/qcom/tsens.h        |  94 +++++++++++++-
> >  5 files changed, 300 insertions(+), 31 deletions(-)
> >
>
>
> --
>  <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
>
> Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
> <http://twitter.com/#!/linaroorg> Twitter |
> <http://www.linaro.org/linaro-blog/> Blog
>