| Message ID | 20200201185218.24473-61-sean.j.christopherson@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | KVM: x86: Introduce KVM cpu caps | expand |
Sean Christopherson <sean.j.christopherson@intel.com> writes: > Drop largepages_enabled, kvm_largepages_enabled() and > kvm_disable_largepages() now that all users are gone. > > Note, largepages_enabled was an x86-only flag that got left in common > KVM code when KVM gained support for multiple architectures. > > No functional change intended. > > Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com> > --- > include/linux/kvm_host.h | 2 -- > virt/kvm/kvm_main.c | 13 ------------- > 2 files changed, 15 deletions(-) > > diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h > index 6d5331b0d937..50105b5c6370 100644 > --- a/include/linux/kvm_host.h > +++ b/include/linux/kvm_host.h > @@ -683,8 +683,6 @@ void kvm_arch_commit_memory_region(struct kvm *kvm, > const struct kvm_memory_slot *old, > const struct kvm_memory_slot *new, > enum kvm_mr_change change); > -bool kvm_largepages_enabled(void); > -void kvm_disable_largepages(void); > /* flush all memory translations */ > void kvm_arch_flush_shadow_all(struct kvm *kvm); > /* flush memory translations pointing to 'slot' */ > diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c > index eb3709d55139..5851a8c27a28 100644 > --- a/virt/kvm/kvm_main.c > +++ b/virt/kvm/kvm_main.c > @@ -149,8 +149,6 @@ static void mark_page_dirty_in_slot(struct kvm_memory_slot *memslot, gfn_t gfn); > __visible bool kvm_rebooting; > EXPORT_SYMBOL_GPL(kvm_rebooting); > > -static bool largepages_enabled = true; > - > #define KVM_EVENT_CREATE_VM 0 > #define KVM_EVENT_DESTROY_VM 1 > static void kvm_uevent_notify_change(unsigned int type, struct kvm *kvm); > @@ -1368,17 +1366,6 @@ int kvm_clear_dirty_log_protect(struct kvm *kvm, > EXPORT_SYMBOL_GPL(kvm_clear_dirty_log_protect); > #endif > > -bool kvm_largepages_enabled(void) > -{ > - return largepages_enabled; > -} > - > -void kvm_disable_largepages(void) > -{ > - largepages_enabled = false; > -} > -EXPORT_SYMBOL_GPL(kvm_disable_largepages); > - > struct kvm_memory_slot *gfn_to_memslot(struct kvm *kvm, gfn_t gfn) > { > return __gfn_to_memslot(kvm_memslots(kvm), gfn); Reviewed-by: Vitaly Kuznetsov <vkuznets@redhat.com>
diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h index 6d5331b0d937..50105b5c6370 100644 --- a/include/linux/kvm_host.h +++ b/include/linux/kvm_host.h @@ -683,8 +683,6 @@ void kvm_arch_commit_memory_region(struct kvm *kvm, const struct kvm_memory_slot *old, const struct kvm_memory_slot *new, enum kvm_mr_change change); -bool kvm_largepages_enabled(void); -void kvm_disable_largepages(void); /* flush all memory translations */ void kvm_arch_flush_shadow_all(struct kvm *kvm); /* flush memory translations pointing to 'slot' */ diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c index eb3709d55139..5851a8c27a28 100644 --- a/virt/kvm/kvm_main.c +++ b/virt/kvm/kvm_main.c @@ -149,8 +149,6 @@ static void mark_page_dirty_in_slot(struct kvm_memory_slot *memslot, gfn_t gfn); __visible bool kvm_rebooting; EXPORT_SYMBOL_GPL(kvm_rebooting); -static bool largepages_enabled = true; - #define KVM_EVENT_CREATE_VM 0 #define KVM_EVENT_DESTROY_VM 1 static void kvm_uevent_notify_change(unsigned int type, struct kvm *kvm); @@ -1368,17 +1366,6 @@ int kvm_clear_dirty_log_protect(struct kvm *kvm, EXPORT_SYMBOL_GPL(kvm_clear_dirty_log_protect); #endif -bool kvm_largepages_enabled(void) -{ - return largepages_enabled; -} - -void kvm_disable_largepages(void) -{ - largepages_enabled = false; -} -EXPORT_SYMBOL_GPL(kvm_disable_largepages); - struct kvm_memory_slot *gfn_to_memslot(struct kvm *kvm, gfn_t gfn) { return __gfn_to_memslot(kvm_memslots(kvm), gfn);
Drop largepages_enabled, kvm_largepages_enabled() and kvm_disable_largepages() now that all users are gone. Note, largepages_enabled was an x86-only flag that got left in common KVM code when KVM gained support for multiple architectures. No functional change intended. Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com> --- include/linux/kvm_host.h | 2 -- virt/kvm/kvm_main.c | 13 ------------- 2 files changed, 15 deletions(-)