| Message ID | 20200303033457.12180-4-mikel@mikelr.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Delegated to: | Bjorn Helgaas |
| Headers | show |
| Series | Fix loading of radeon BIOS from 32-bit EFI | expand |
On Mon, Mar 02, 2020 at 10:34:56PM -0500, Mikel Rychliski wrote: > Now that pci_platform_rom creates a new mapping to access the ROM > image, we should remove this mapping after extracting the BIOS. This and the next patch really need to be folded into the previous one to avoid regressions (assuming my other suggestion doesn't work for some reason).
diff --git a/drivers/gpu/drm/radeon/radeon_bios.c b/drivers/gpu/drm/radeon/radeon_bios.c index c3ae4c92a115..712b88d88957 100644 --- a/drivers/gpu/drm/radeon/radeon_bios.c +++ b/drivers/gpu/drm/radeon/radeon_bios.c @@ -123,6 +123,7 @@ static bool radeon_read_platform_bios(struct radeon_device *rdev) return false; memcpy_fromio(rdev->bios, bios, size); + iounmap(bios); if (size == 0 || rdev->bios[0] != 0x55 || rdev->bios[1] != 0xaa) { kfree(rdev->bios);
Now that pci_platform_rom creates a new mapping to access the ROM image, we should remove this mapping after extracting the BIOS. Signed-off-by: Mikel Rychliski <mikel@mikelr.com> --- drivers/gpu/drm/radeon/radeon_bios.c | 1 + 1 file changed, 1 insertion(+)