| Message ID | 1C2C8CD5-4BF0-40AE-932A-4AD506664B9D@norphonic.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v6,1/2] Driver for TI HDC20x0 humidity and temperature sensors | expand |
On Tue, 17 Mar 2020 20:09:48 +0000, Eugene Zalkonnikov wrote: > > Device tree bindings for the HDC2010/2080 driver. > > Signed-off-by: Eugene Zaikonnikov <eugene.zaikonnikov@norphonic.com> > > diff -uprN linux-5.3.8/Documentation/devicetree/bindings/iio/humidity/ti,hdc2010.yaml linux-5.3.8_docs/Documentation/devicetree/bindings/iio/humidity/ti,hdc2010.yaml > --- linux-5.3.8/Documentation/devicetree/bindings/iio/humidity/ti,hdc2010.yaml 1970-01-01 01:00:00.000000000 +0100 > +++ linux-5.3.8_docs/Documentation/devicetree/bindings/iio/humidity/ti,hdc2010.yaml 2020-02-12 14:28:42.562903814 +0100 > @@ -0,0 +1,43 @@ > +# SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/humidity/hdc2010.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: HDC2010/HDC2080 humidity and temperature iio sensors > + > +maintainers: > + - Eugene Zaikonnikov <eugene.zaikonnikov@norophonic.com> > + > +description: | > + Relative humidity and tempereature sensors on I2C bus > + > + Datasheets are available at: > + http://www.ti.com/product/HDC2010/datasheet > + http://www.ti.com/product/HDC2080/datasheet > + > +properties: > + compatible: > + enum: > + - ti,hdc2010 > + - ti,hdc2080 > + > + vddd-supply: > + description: > + digital voltage regulator (see regulator/regulator.txt) > + maxItems: 1 > + > +required: > + - compatible > + > +examples: > + - | > + i2c0 { > + #address-cells = <1>; > + #size-cells = <0>; > + > + hdc200x@40 { > + compatible = "ti,hdc2010"; > + reg = <0x40>; > + }; > + }; > My bot found errors running 'make dt_binding_check' on your patch: Documentation/devicetree/bindings/iio/humidity/ti,hdc2010.yaml: $id: relative path/filename doesn't match actual path or filename expected: http://devicetree.org/schemas/iio/humidity/ti,hdc2010.yaml# See https://patchwork.ozlabs.org/patch/1256878 Please check and re-submit.
On Tue, 17 Mar 2020 20:09:48 +0000 Eugene Zalkonnikov <ez@norphonic.com> wrote: > Device tree bindings for the HDC2010/2080 driver. > > Signed-off-by: Eugene Zaikonnikov <eugene.zaikonnikov@norphonic.com> Hi Eugene A few minor things inline Jonathan > > diff -uprN linux-5.3.8/Documentation/devicetree/bindings/iio/humidity/ti,hdc2010.yaml linux-5.3.8_docs/Documentation/devicetree/bindings/iio/humidity/ti,hdc2010.yaml > --- linux-5.3.8/Documentation/devicetree/bindings/iio/humidity/ti,hdc2010.yaml 1970-01-01 01:00:00.000000000 +0100 > +++ linux-5.3.8_docs/Documentation/devicetree/bindings/iio/humidity/ti,hdc2010.yaml 2020-02-12 14:28:42.562903814 +0100 > @@ -0,0 +1,43 @@ > +# SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/humidity/hdc2010.yaml# As Rob's bot pointed out... ti,hdc2010.yaml preferred. > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: HDC2010/HDC2080 humidity and temperature iio sensors > + > +maintainers: > + - Eugene Zaikonnikov <eugene.zaikonnikov@norophonic.com> > + > +description: | > + Relative humidity and tempereature sensors on I2C bus > + > + Datasheets are available at: > + http://www.ti.com/product/HDC2010/datasheet > + http://www.ti.com/product/HDC2080/datasheet > + > +properties: > + compatible: > + enum: > + - ti,hdc2010 > + - ti,hdc2080 > + > + vddd-supply: ddd rather than dd? > + description: > + digital voltage regulator (see regulator/regulator.txt) For main supply probably don't need to bother with description. > + maxItems: 1 > + > +required: > + - compatible > + > +examples: > + - | > + i2c0 { > + #address-cells = <1>; > + #size-cells = <0>; > + > + hdc200x@40 { Naming should be 'generic'. humidity@40 { Is probably appropriate though not on the explicit list in the devicetree spec yet. > + compatible = "ti,hdc2010"; > + reg = <0x40>; > + }; > + }; >
diff -uprN linux-5.3.8/Documentation/devicetree/bindings/iio/humidity/ti,hdc2010.yaml linux-5.3.8_docs/Documentation/devicetree/bindings/iio/humidity/ti,hdc2010.yaml --- linux-5.3.8/Documentation/devicetree/bindings/iio/humidity/ti,hdc2010.yaml 1970-01-01 01:00:00.000000000 +0100 +++ linux-5.3.8_docs/Documentation/devicetree/bindings/iio/humidity/ti,hdc2010.yaml 2020-02-12 14:28:42.562903814 +0100 @@ -0,0 +1,43 @@ +# SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/iio/humidity/hdc2010.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: HDC2010/HDC2080 humidity and temperature iio sensors + +maintainers: + - Eugene Zaikonnikov <eugene.zaikonnikov@norophonic.com> + +description: | + Relative humidity and tempereature sensors on I2C bus + + Datasheets are available at: + http://www.ti.com/product/HDC2010/datasheet + http://www.ti.com/product/HDC2080/datasheet + +properties: + compatible: + enum: + - ti,hdc2010 + - ti,hdc2080 + + vddd-supply: + description: + digital voltage regulator (see regulator/regulator.txt) + maxItems: 1 + +required: + - compatible + +examples: + - | + i2c0 { + #address-cells = <1>; + #size-cells = <0>; + + hdc200x@40 { + compatible = "ti,hdc2010"; + reg = <0x40>; + }; + };
Device tree bindings for the HDC2010/2080 driver. Signed-off-by: Eugene Zaikonnikov <eugene.zaikonnikov@norphonic.com>