| Message ID | 20200405133726.24154-1-hdegoede@redhat.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | c8b78f24c1247b7bd0882885c672d9dec5800bc6 |
| Headers | show |
| Series | [v3] ASoC: Intel: bytcr_rt5640: Add quirk for MPMAN MPWIN895CL tablet | expand |
Note the v3 in the Subject is my bad, this is the first version / v1 of this patch. Regards, Hans On 4/5/20 3:37 PM, Hans de Goede wrote: > The MPMAN MPWIN895CL tablet almost fully works with out default settings. > The only problem is that it has only 1 speaker so any sounds only playing > on the right channel get lost. > > Add a quirk for this model using the default settings + MONO_SPEAKER. > > Signed-off-by: Hans de Goede <hdegoede@redhat.com> > --- > sound/soc/intel/boards/bytcr_rt5640.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/sound/soc/intel/boards/bytcr_rt5640.c b/sound/soc/intel/boards/bytcr_rt5640.c > index 6bd9ae813be2..d14d5f7db168 100644 > --- a/sound/soc/intel/boards/bytcr_rt5640.c > +++ b/sound/soc/intel/boards/bytcr_rt5640.c > @@ -591,6 +591,17 @@ static const struct dmi_system_id byt_rt5640_quirk_table[] = { > BYT_RT5640_SSP0_AIF1 | > BYT_RT5640_MCLK_EN), > }, > + { > + /* MPMAN MPWIN895CL */ > + .matches = { > + DMI_EXACT_MATCH(DMI_SYS_VENDOR, "MPMAN"), > + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "MPWIN8900CL"), > + }, > + .driver_data = (void *)(BYTCR_INPUT_DEFAULTS | > + BYT_RT5640_MONO_SPEAKER | > + BYT_RT5640_SSP0_AIF1 | > + BYT_RT5640_MCLK_EN), > + }, > { /* MSI S100 tablet */ > .matches = { > DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Micro-Star International Co., Ltd."), >
On 4/5/20 8:37 AM, Hans de Goede wrote: > The MPMAN MPWIN895CL tablet almost fully works with out default settings. > The only problem is that it has only 1 speaker so any sounds only playing > on the right channel get lost. > > Add a quirk for this model using the default settings + MONO_SPEAKER. > > Signed-off-by: Hans de Goede <hdegoede@redhat.com> Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Thanks Hans! > --- > sound/soc/intel/boards/bytcr_rt5640.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/sound/soc/intel/boards/bytcr_rt5640.c b/sound/soc/intel/boards/bytcr_rt5640.c > index 6bd9ae813be2..d14d5f7db168 100644 > --- a/sound/soc/intel/boards/bytcr_rt5640.c > +++ b/sound/soc/intel/boards/bytcr_rt5640.c > @@ -591,6 +591,17 @@ static const struct dmi_system_id byt_rt5640_quirk_table[] = { > BYT_RT5640_SSP0_AIF1 | > BYT_RT5640_MCLK_EN), > }, > + { > + /* MPMAN MPWIN895CL */ > + .matches = { > + DMI_EXACT_MATCH(DMI_SYS_VENDOR, "MPMAN"), > + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "MPWIN8900CL"), > + }, > + .driver_data = (void *)(BYTCR_INPUT_DEFAULTS | > + BYT_RT5640_MONO_SPEAKER | > + BYT_RT5640_SSP0_AIF1 | > + BYT_RT5640_MCLK_EN), > + }, > { /* MSI S100 tablet */ > .matches = { > DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Micro-Star International Co., Ltd."), >
Hi, On 4/6/20 12:55 AM, Pierre-Louis Bossart wrote: > > > On 4/5/20 8:37 AM, Hans de Goede wrote: >> The MPMAN MPWIN895CL tablet almost fully works with out default settings. >> The only problem is that it has only 1 speaker so any sounds only playing >> on the right channel get lost. >> >> Add a quirk for this model using the default settings + MONO_SPEAKER. >> >> Signed-off-by: Hans de Goede <hdegoede@redhat.com> > > Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Thanks. Can you please also review this quirk addition ? : https://patchwork.kernel.org/patch/11471275/ Regards, Hans >> --- >> sound/soc/intel/boards/bytcr_rt5640.c | 11 +++++++++++ >> 1 file changed, 11 insertions(+) >> >> diff --git a/sound/soc/intel/boards/bytcr_rt5640.c b/sound/soc/intel/boards/bytcr_rt5640.c >> index 6bd9ae813be2..d14d5f7db168 100644 >> --- a/sound/soc/intel/boards/bytcr_rt5640.c >> +++ b/sound/soc/intel/boards/bytcr_rt5640.c >> @@ -591,6 +591,17 @@ static const struct dmi_system_id byt_rt5640_quirk_table[] = { >> BYT_RT5640_SSP0_AIF1 | >> BYT_RT5640_MCLK_EN), >> }, >> + { >> + /* MPMAN MPWIN895CL */ >> + .matches = { >> + DMI_EXACT_MATCH(DMI_SYS_VENDOR, "MPMAN"), >> + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "MPWIN8900CL"), >> + }, >> + .driver_data = (void *)(BYTCR_INPUT_DEFAULTS | >> + BYT_RT5640_MONO_SPEAKER | >> + BYT_RT5640_SSP0_AIF1 | >> + BYT_RT5640_MCLK_EN), >> + }, >> { /* MSI S100 tablet */ >> .matches = { >> DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Micro-Star International Co., Ltd."), >> >
diff --git a/sound/soc/intel/boards/bytcr_rt5640.c b/sound/soc/intel/boards/bytcr_rt5640.c index 6bd9ae813be2..d14d5f7db168 100644 --- a/sound/soc/intel/boards/bytcr_rt5640.c +++ b/sound/soc/intel/boards/bytcr_rt5640.c @@ -591,6 +591,17 @@ static const struct dmi_system_id byt_rt5640_quirk_table[] = { BYT_RT5640_SSP0_AIF1 | BYT_RT5640_MCLK_EN), }, + { + /* MPMAN MPWIN895CL */ + .matches = { + DMI_EXACT_MATCH(DMI_SYS_VENDOR, "MPMAN"), + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "MPWIN8900CL"), + }, + .driver_data = (void *)(BYTCR_INPUT_DEFAULTS | + BYT_RT5640_MONO_SPEAKER | + BYT_RT5640_SSP0_AIF1 | + BYT_RT5640_MCLK_EN), + }, { /* MSI S100 tablet */ .matches = { DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Micro-Star International Co., Ltd."),
The MPMAN MPWIN895CL tablet almost fully works with out default settings. The only problem is that it has only 1 speaker so any sounds only playing on the right channel get lost. Add a quirk for this model using the default settings + MONO_SPEAKER. Signed-off-by: Hans de Goede <hdegoede@redhat.com> --- sound/soc/intel/boards/bytcr_rt5640.c | 11 +++++++++++ 1 file changed, 11 insertions(+)