Message ID | 20200415110939.9481-1-roger.pau@citrix.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | x86/altp2m: add missing break | expand |
On Wed, Apr 15, 2020 at 01:09:39PM +0200, Roger Pau Monne wrote: > Add a missing break in the HVMOP_altp2m_set_visibility case, or else > code flow will continue into the default case and trigger the assert. > > Fixes: 3fd3e9303ec4b1 ('x86/altp2m: hypercall to set altp2m view visibility') > Coverity-ID: 1461759 > Signed-off-by: Roger Pau Monné <roger.pau@citrix.com> Reviewed-by: Wei Liu <wl@xen.org>
diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c index 6f6f3f73a8..45959d3412 100644 --- a/xen/arch/x86/hvm/hvm.c +++ b/xen/arch/x86/hvm/hvm.c @@ -4798,6 +4798,7 @@ static int do_altp2m_op( else rc = p2m_set_altp2m_view_visibility(d, idx, a.u.set_visibility.visible); + break; } default:
Add a missing break in the HVMOP_altp2m_set_visibility case, or else code flow will continue into the default case and trigger the assert. Fixes: 3fd3e9303ec4b1 ('x86/altp2m: hypercall to set altp2m view visibility') Coverity-ID: 1461759 Signed-off-by: Roger Pau Monné <roger.pau@citrix.com> --- xen/arch/x86/hvm/hvm.c | 1 + 1 file changed, 1 insertion(+)