[PULL,0/1] Linux user for 5.0 patches

Message ID	20200416152829.790561-1-laurent@vivier.eu (mailing list archive)
State	New, archived
Headers	show Return-Path: <SRS0=DIU2=6A=nongnu.org=qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@kernel.org> DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7FD6C21927 From: Laurent Vivier <laurent@vivier.eu> To: qemu-devel@nongnu.org Subject: [PULL 0/1] Linux user for 5.0 patches Date: Thu, 16 Apr 2020 17:28:28 +0200 Message-Id: <20200416152829.790561-1-laurent@vivier.eu> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: list Cc: Riku Voipio <riku.voipio@iki.fi>, Laurent Vivier <laurent@vivier.eu> Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" <qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org>

Laurent Vivier April 16, 2020, 3:28 p.m. UTC

The following changes since commit 20038cd7a8412feeb49c01f6ede89e36c8995472:

  Update version for v5.0.0-rc3 release (2020-04-15 20:51:54 +0100)

are available in the Git repository at:

  git://github.com/vivier/qemu.git tags/linux-user-for-5.0-pull-request

for you to fetch changes up to 386d38656889a40d29b514ee6f34997ca18f741e:

  linux-user/syscall.c: add target-to-host mapping for epoll_create1() (2020-04-16 09:24:22 +0200)

----------------------------------------------------------------
Fix epoll_create1() for qemu-alpha

----------------------------------------------------------------

Sergei Trofimovich (1):
  linux-user/syscall.c: add target-to-host mapping for epoll_create1()

 linux-user/syscall.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Peter Maydell April 16, 2020, 4:03 p.m. UTC | #1

On Thu, 16 Apr 2020 at 16:29, Laurent Vivier <laurent@vivier.eu> wrote:
>
> The following changes since commit 20038cd7a8412feeb49c01f6ede89e36c8995472:
>
>   Update version for v5.0.0-rc3 release (2020-04-15 20:51:54 +0100)
>
> are available in the Git repository at:
>
>   git://github.com/vivier/qemu.git tags/linux-user-for-5.0-pull-request
>
> for you to fetch changes up to 386d38656889a40d29b514ee6f34997ca18f741e:
>
>   linux-user/syscall.c: add target-to-host mapping for epoll_create1() (2020-04-16 09:24:22 +0200)
>
> ----------------------------------------------------------------
> Fix epoll_create1() for qemu-alpha
>
> ----------------------------------------------------------------

How critical is this bug fix? After rc3, I really don't want
to have to create an rc4 unless it's unavoidable...

thanks
-- PMM

Laurent Vivier April 16, 2020, 5:16 p.m. UTC | #2

Le 16/04/2020 à 18:03, Peter Maydell a écrit :
> On Thu, 16 Apr 2020 at 16:29, Laurent Vivier <laurent@vivier.eu> wrote:
>>
>> The following changes since commit 20038cd7a8412feeb49c01f6ede89e36c8995472:
>>
>>   Update version for v5.0.0-rc3 release (2020-04-15 20:51:54 +0100)
>>
>> are available in the Git repository at:
>>
>>   git://github.com/vivier/qemu.git tags/linux-user-for-5.0-pull-request
>>
>> for you to fetch changes up to 386d38656889a40d29b514ee6f34997ca18f741e:
>>
>>   linux-user/syscall.c: add target-to-host mapping for epoll_create1() (2020-04-16 09:24:22 +0200)
>>
>> ----------------------------------------------------------------
>> Fix epoll_create1() for qemu-alpha
>>
>> ----------------------------------------------------------------
> 
> How critical is this bug fix? After rc3, I really don't want
> to have to create an rc4 unless it's unavoidable...

See the launchpad bug (https://bugs.gentoo.org/717548): on alpha, it
prevents the use of python3 in gentoo chroot, and thus we can't use
emerge to install packages. It also impacts cmake on debian (see
https://bugs.launchpad.net/bugs/1860553).

But it's not a regression, so up to you to reject it. It appears now
because most of the distro have switched from python2 to python3.

It's a low risk change, only in linux-user and for archs that have a
different EPOLL_CLOEXEC value.

Thanks,
Laurent

Peter Maydell April 16, 2020, 7:08 p.m. UTC | #3

On Thu, 16 Apr 2020 at 18:16, Laurent Vivier <laurent@vivier.eu> wrote:
>
> Le 16/04/2020 à 18:03, Peter Maydell a écrit :
> > On Thu, 16 Apr 2020 at 16:29, Laurent Vivier <laurent@vivier.eu> wrote:
> >>
> >> The following changes since commit 20038cd7a8412feeb49c01f6ede89e36c8995472:
> >>
> >>   Update version for v5.0.0-rc3 release (2020-04-15 20:51:54 +0100)
> >>
> >> are available in the Git repository at:
> >>
> >>   git://github.com/vivier/qemu.git tags/linux-user-for-5.0-pull-request
> >>
> >> for you to fetch changes up to 386d38656889a40d29b514ee6f34997ca18f741e:
> >>
> >>   linux-user/syscall.c: add target-to-host mapping for epoll_create1() (2020-04-16 09:24:22 +0200)
> >>
> >> ----------------------------------------------------------------
> >> Fix epoll_create1() for qemu-alpha
> >>
> >> ----------------------------------------------------------------
> >
> > How critical is this bug fix? After rc3, I really don't want
> > to have to create an rc4 unless it's unavoidable...
>
> See the launchpad bug (https://bugs.gentoo.org/717548): on alpha, it
> prevents the use of python3 in gentoo chroot, and thus we can't use
> emerge to install packages. It also impacts cmake on debian (see
> https://bugs.launchpad.net/bugs/1860553).
>
> But it's not a regression, so up to you to reject it. It appears now
> because most of the distro have switched from python2 to python3.
>
> It's a low risk change, only in linux-user and for archs that have a
> different EPOLL_CLOEXEC value.

Thanks for the explanation. I think that I'll put it to one
side and if we need an rc4 for some other reason it can go in,
but it's not sufficiently major to merit an rc4 by itself.

-- PMM

Laurent Vivier April 16, 2020, 7:15 p.m. UTC | #4

Le 16/04/2020 à 21:08, Peter Maydell a écrit :
> On Thu, 16 Apr 2020 at 18:16, Laurent Vivier <laurent@vivier.eu> wrote:
>>
>> Le 16/04/2020 à 18:03, Peter Maydell a écrit :
>>> On Thu, 16 Apr 2020 at 16:29, Laurent Vivier <laurent@vivier.eu> wrote:
>>>>
>>>> The following changes since commit 20038cd7a8412feeb49c01f6ede89e36c8995472:
>>>>
>>>>   Update version for v5.0.0-rc3 release (2020-04-15 20:51:54 +0100)
>>>>
>>>> are available in the Git repository at:
>>>>
>>>>   git://github.com/vivier/qemu.git tags/linux-user-for-5.0-pull-request
>>>>
>>>> for you to fetch changes up to 386d38656889a40d29b514ee6f34997ca18f741e:
>>>>
>>>>   linux-user/syscall.c: add target-to-host mapping for epoll_create1() (2020-04-16 09:24:22 +0200)
>>>>
>>>> ----------------------------------------------------------------
>>>> Fix epoll_create1() for qemu-alpha
>>>>
>>>> ----------------------------------------------------------------
>>>
>>> How critical is this bug fix? After rc3, I really don't want
>>> to have to create an rc4 unless it's unavoidable...
>>
>> See the launchpad bug (https://bugs.gentoo.org/717548): on alpha, it
>> prevents the use of python3 in gentoo chroot, and thus we can't use
>> emerge to install packages. It also impacts cmake on debian (see
>> https://bugs.launchpad.net/bugs/1860553).
>>
>> But it's not a regression, so up to you to reject it. It appears now
>> because most of the distro have switched from python2 to python3.
>>
>> It's a low risk change, only in linux-user and for archs that have a
>> different EPOLL_CLOEXEC value.
> 
> Thanks for the explanation. I think that I'll put it to one
> side and if we need an rc4 for some other reason it can go in,
> but it's not sufficiently major to merit an rc4 by itself.
> 

Thank you, I agree.

Laurent

Peter Maydell April 20, 2020, 6:55 p.m. UTC | #5

On Thu, 16 Apr 2020 at 20:08, Peter Maydell <peter.maydell@linaro.org> wrote:
>
> On Thu, 16 Apr 2020 at 18:16, Laurent Vivier <laurent@vivier.eu> wrote:
> >
> > Le 16/04/2020 à 18:03, Peter Maydell a écrit :
> > > On Thu, 16 Apr 2020 at 16:29, Laurent Vivier <laurent@vivier.eu> wrote:
> > >>
> > >> The following changes since commit 20038cd7a8412feeb49c01f6ede89e36c8995472:
> > >>
> > >>   Update version for v5.0.0-rc3 release (2020-04-15 20:51:54 +0100)
> > >>
> > >> are available in the Git repository at:
> > >>
> > >>   git://github.com/vivier/qemu.git tags/linux-user-for-5.0-pull-request
> > >>
> > >> for you to fetch changes up to 386d38656889a40d29b514ee6f34997ca18f741e:
> > >>
> > >>   linux-user/syscall.c: add target-to-host mapping for epoll_create1() (2020-04-16 09:24:22 +0200)
> > >>
> > >> ----------------------------------------------------------------
> > >> Fix epoll_create1() for qemu-alpha
> > >>
> > >> ----------------------------------------------------------------
> > >
> > > How critical is this bug fix? After rc3, I really don't want
> > > to have to create an rc4 unless it's unavoidable...
> >
> > See the launchpad bug (https://bugs.gentoo.org/717548): on alpha, it
> > prevents the use of python3 in gentoo chroot, and thus we can't use
> > emerge to install packages. It also impacts cmake on debian (see
> > https://bugs.launchpad.net/bugs/1860553).
> >
> > But it's not a regression, so up to you to reject it. It appears now
> > because most of the distro have switched from python2 to python3.
> >
> > It's a low risk change, only in linux-user and for archs that have a
> > different EPOLL_CLOEXEC value.
>
> Thanks for the explanation. I think that I'll put it to one
> side and if we need an rc4 for some other reason it can go in,
> but it's not sufficiently major to merit an rc4 by itself.

We needed an rc4 for the iscsi fix, so I have applied this pullreq.

thanks
-- PMM

[PULL,0/1] Linux user for 5.0 patches

Pull-request

Message

Comments