mbox series

[0/3] K210 support fixes

Message ID 20200414044326.103884-1-damien.lemoal@wdc.com (mailing list archive)
Headers show
Series K210 support fixes | expand

Message

Damien Le Moal April 14, 2020, 4:43 a.m. UTC
Palmer,

The first 2 patches of this series are your patches for the builtin DTB
fixed up and tested. The third patch adds necessary updates to the
K210 defconfig. Please review.

Damien Le Moal (1):
  riscv: K210: Update defconfig

Palmer Dabbelt (2):
  riscv: Allow device trees to be built into the kernel
  riscv: K210: Add a built-in device tree

 arch/riscv/Kbuild                       |  1 +
 arch/riscv/Kconfig                      |  5 ++++
 arch/riscv/Kconfig.socs                 | 17 ++++++++++-
 arch/riscv/boot/dts/Makefile            |  2 ++
 arch/riscv/boot/dts/kendryte/Makefile   |  4 ++-
 arch/riscv/configs/nommu_k210_defconfig |  7 ++---
 arch/riscv/include/asm/soc.h            | 39 +++++++++++++++++++++++++
 arch/riscv/kernel/setup.c               |  4 +++
 arch/riscv/kernel/soc.c                 | 27 +++++++++++++++++
 arch/riscv/kernel/vmlinux.lds.S         |  5 ++++
 arch/riscv/mm/init.c                    |  9 ++++++
 drivers/soc/kendryte/k210-sysctl.c      | 12 ++++++++
 12 files changed, 125 insertions(+), 7 deletions(-)

Comments

Palmer Dabbelt April 21, 2020, 10:24 p.m. UTC | #1
On Mon, 13 Apr 2020 21:43:23 PDT (-0700), Damien Le Moal wrote:
> Palmer,
>
> The first 2 patches of this series are your patches for the builtin DTB
> fixed up and tested. The third patch adds necessary updates to the
> K210 defconfig. Please review.
>
> Damien Le Moal (1):
>   riscv: K210: Update defconfig
>
> Palmer Dabbelt (2):
>   riscv: Allow device trees to be built into the kernel
>   riscv: K210: Add a built-in device tree
>
>  arch/riscv/Kbuild                       |  1 +
>  arch/riscv/Kconfig                      |  5 ++++
>  arch/riscv/Kconfig.socs                 | 17 ++++++++++-
>  arch/riscv/boot/dts/Makefile            |  2 ++
>  arch/riscv/boot/dts/kendryte/Makefile   |  4 ++-
>  arch/riscv/configs/nommu_k210_defconfig |  7 ++---
>  arch/riscv/include/asm/soc.h            | 39 +++++++++++++++++++++++++
>  arch/riscv/kernel/setup.c               |  4 +++
>  arch/riscv/kernel/soc.c                 | 27 +++++++++++++++++
>  arch/riscv/kernel/vmlinux.lds.S         |  5 ++++
>  arch/riscv/mm/init.c                    |  9 ++++++
>  drivers/soc/kendryte/k210-sysctl.c      | 12 ++++++++
>  12 files changed, 125 insertions(+), 7 deletions(-)

Is that PMP thing necessary as well?

I've put these (along with the PMP fix) on for-next.

Thanks!
Damien Le Moal April 22, 2020, 12:37 a.m. UTC | #2
On 2020/04/22 7:24, Palmer Dabbelt wrote:
> On Mon, 13 Apr 2020 21:43:23 PDT (-0700), Damien Le Moal wrote:
>> Palmer,
>>
>> The first 2 patches of this series are your patches for the builtin DTB
>> fixed up and tested. The third patch adds necessary updates to the
>> K210 defconfig. Please review.
>>
>> Damien Le Moal (1):
>>   riscv: K210: Update defconfig
>>
>> Palmer Dabbelt (2):
>>   riscv: Allow device trees to be built into the kernel
>>   riscv: K210: Add a built-in device tree
>>
>>  arch/riscv/Kbuild                       |  1 +
>>  arch/riscv/Kconfig                      |  5 ++++
>>  arch/riscv/Kconfig.socs                 | 17 ++++++++++-
>>  arch/riscv/boot/dts/Makefile            |  2 ++
>>  arch/riscv/boot/dts/kendryte/Makefile   |  4 ++-
>>  arch/riscv/configs/nommu_k210_defconfig |  7 ++---
>>  arch/riscv/include/asm/soc.h            | 39 +++++++++++++++++++++++++
>>  arch/riscv/kernel/setup.c               |  4 +++
>>  arch/riscv/kernel/soc.c                 | 27 +++++++++++++++++
>>  arch/riscv/kernel/vmlinux.lds.S         |  5 ++++
>>  arch/riscv/mm/init.c                    |  9 ++++++
>>  drivers/soc/kendryte/k210-sysctl.c      | 12 ++++++++
>>  12 files changed, 125 insertions(+), 7 deletions(-)
> 
> Is that PMP thing necessary as well?

Yes, it is still necessary. I replied to your patch using traps instead of the
ifdef. It is working fine.

> 
> I've put these (along with the PMP fix) on for-next.

OK. Thanks. I looked and I think everything is in order. I will test again with
that tree.

> 
> Thanks!
>
Damien Le Moal April 23, 2020, 2:30 a.m. UTC | #3
On 2020/04/22 7:24, Palmer Dabbelt wrote:
> On Mon, 13 Apr 2020 21:43:23 PDT (-0700), Damien Le Moal wrote:
>> Palmer,
>>
>> The first 2 patches of this series are your patches for the builtin DTB
>> fixed up and tested. The third patch adds necessary updates to the
>> K210 defconfig. Please review.
>>
>> Damien Le Moal (1):
>>   riscv: K210: Update defconfig
>>
>> Palmer Dabbelt (2):
>>   riscv: Allow device trees to be built into the kernel
>>   riscv: K210: Add a built-in device tree
>>
>>  arch/riscv/Kbuild                       |  1 +
>>  arch/riscv/Kconfig                      |  5 ++++
>>  arch/riscv/Kconfig.socs                 | 17 ++++++++++-
>>  arch/riscv/boot/dts/Makefile            |  2 ++
>>  arch/riscv/boot/dts/kendryte/Makefile   |  4 ++-
>>  arch/riscv/configs/nommu_k210_defconfig |  7 ++---
>>  arch/riscv/include/asm/soc.h            | 39 +++++++++++++++++++++++++
>>  arch/riscv/kernel/setup.c               |  4 +++
>>  arch/riscv/kernel/soc.c                 | 27 +++++++++++++++++
>>  arch/riscv/kernel/vmlinux.lds.S         |  5 ++++
>>  arch/riscv/mm/init.c                    |  9 ++++++
>>  drivers/soc/kendryte/k210-sysctl.c      | 12 ++++++++
>>  12 files changed, 125 insertions(+), 7 deletions(-)
> 
> Is that PMP thing necessary as well?
> 
> I've put these (along with the PMP fix) on for-next.

Is your for-next branch for the next 5.8 merge window ? Or is it for 5.7.0-rcX
fixes ?

These patches complete the K210 support. We should have that in 5.7 instead of
leaving the half backed k210 support in that version...


> 
> Thanks!
>