| Message ID | 20200426094037.23048-1-yanaijie@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | c26b01d5ec1ab4dbfbdeb93ef4bc9e34951b6688 |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | ath5k: remove conversion to bool in ath5k_ani_calibration() | expand |
Jason Yan <yanaijie@huawei.com> wrote: > The '>' expression itself is bool, no need to convert it to bool again. > This fixes the following coccicheck warning: > > drivers/net/wireless/ath/ath5k/ani.c:504:56-61: WARNING: conversion to > bool not needed here > > Signed-off-by: Jason Yan <yanaijie@huawei.com> > Signed-off-by: Kalle Valo <kvalo@codeaurora.org> Patch applied to ath-next branch of ath.git, thanks. c26b01d5ec1a ath5k: remove conversion to bool in ath5k_ani_calibration()
diff --git a/drivers/net/wireless/ath/ath5k/ani.c b/drivers/net/wireless/ath/ath5k/ani.c index 0624333f5430..850c608b43a3 100644 --- a/drivers/net/wireless/ath/ath5k/ani.c +++ b/drivers/net/wireless/ath/ath5k/ani.c @@ -501,7 +501,7 @@ ath5k_ani_calibration(struct ath5k_hw *ah) if (as->ofdm_errors > ofdm_high || as->cck_errors > cck_high) { /* too many PHY errors - we have to raise immunity */ - bool ofdm_flag = as->ofdm_errors > ofdm_high ? true : false; + bool ofdm_flag = as->ofdm_errors > ofdm_high; ath5k_ani_raise_immunity(ah, as, ofdm_flag); ath5k_ani_period_restart(as);
The '>' expression itself is bool, no need to convert it to bool again. This fixes the following coccicheck warning: drivers/net/wireless/ath/ath5k/ani.c:504:56-61: WARNING: conversion to bool not needed here Signed-off-by: Jason Yan <yanaijie@huawei.com> --- drivers/net/wireless/ath/ath5k/ani.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)