| Message ID | 20200427104403.14598-1-weiyongjun1@huawei.com (mailing list archive) |
|---|---|
| State | Rejected |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | [net-next] ath11k: remove redundant dev_err call in ath11k_ahb_probe() | expand |
Wei Yongjun <weiyongjun1@huawei.com> wrote: > There is a error message within devm_ioremap_resource > already, so remove the dev_err call to avoid redundant > error message. > > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> I don't see harm having two error messages and having an error message within ath11k makes it easier to find the exact location, so I'm dropping this.
diff --git a/drivers/net/wireless/ath/ath11k/ahb.c b/drivers/net/wireless/ath/ath11k/ahb.c index e7e3e64c07aa..7d3d1cc6f39f 100644 --- a/drivers/net/wireless/ath/ath11k/ahb.c +++ b/drivers/net/wireless/ath/ath11k/ahb.c @@ -897,10 +897,8 @@ static int ath11k_ahb_probe(struct platform_device *pdev) } mem = devm_ioremap_resource(&pdev->dev, mem_res); - if (IS_ERR(mem)) { - dev_err(&pdev->dev, "ioremap error\n"); + if (IS_ERR(mem)) return PTR_ERR(mem); - } ret = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32)); if (ret) {
There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> --- drivers/net/wireless/ath/ath11k/ahb.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)