| Message ID | 20200429111539.42103-2-kwolf@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | backup: Make sure that source and target size match | expand |
29.04.2020 14:15, Kevin Wolf wrote: > bdrv_get_device_name() will be an empty string with modern management > tools that don't use -drive. Use bdrv_get_device_or_node_name() instead > so that the node name is used if the BlockBackend is anonymous. > > While at it, start with upper case to make the message consistent with > the rest of the function. > > Signed-off-by: Kevin Wolf<kwolf@redhat.com> Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
On Wed 29 Apr 2020 01:15:37 PM CEST, Kevin Wolf wrote: > bdrv_get_device_name() will be an empty string with modern management > tools that don't use -drive. Use bdrv_get_device_or_node_name() instead > so that the node name is used if the BlockBackend is anonymous. > > While at it, start with upper case to make the message consistent with > the rest of the function. > > Signed-off-by: Kevin Wolf <kwolf@redhat.com> Reviewed-by: Alberto Garcia <berto@igalia.com> Berto
diff --git a/block/backup.c b/block/backup.c index a7a7dcaf4c..c4c3b8cd46 100644 --- a/block/backup.c +++ b/block/backup.c @@ -400,8 +400,8 @@ BlockJob *backup_job_create(const char *job_id, BlockDriverState *bs, len = bdrv_getlength(bs); if (len < 0) { - error_setg_errno(errp, -len, "unable to get length for '%s'", - bdrv_get_device_name(bs)); + error_setg_errno(errp, -len, "Unable to get length for '%s'", + bdrv_get_device_or_node_name(bs)); goto error; }
bdrv_get_device_name() will be an empty string with modern management tools that don't use -drive. Use bdrv_get_device_or_node_name() instead so that the node name is used if the BlockBackend is anonymous. While at it, start with upper case to make the message consistent with the rest of the function. Signed-off-by: Kevin Wolf <kwolf@redhat.com> --- block/backup.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)