| Message ID | 20200425083503.149656-1-chentao107@huawei.com (mailing list archive) |
|---|---|
| State | Rejected |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | rtw88: mac: Make some founctions static | expand |
ChenTao <chentao107@huawei.com> wrote: > Fix the following warning: > > vers/net/wireless/realtek/rtw88/mac.c:699:5: warning: > symbol '__rtw_download_firmware' was not declared. Should it be static? > drivers/net/wireless/realtek/rtw88/mac.c:863:5: warning: > symbol '__rtw_download_firmware_legacy' was not declared. Should it be static? > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: ChenTao <chentao107@huawei.com> Already fixed: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git/commit/?id=3d8bf50860c7de09c9713b97ec2f87ad42338c7e
diff --git a/drivers/net/wireless/realtek/rtw88/mac.c b/drivers/net/wireless/realtek/rtw88/mac.c index 645207a01525..f5bf5bab9454 100644 --- a/drivers/net/wireless/realtek/rtw88/mac.c +++ b/drivers/net/wireless/realtek/rtw88/mac.c @@ -696,7 +696,7 @@ static void download_firmware_end_flow(struct rtw_dev *rtwdev) rtw_write16(rtwdev, REG_MCUFW_CTRL, fw_ctrl); } -int __rtw_download_firmware(struct rtw_dev *rtwdev, struct rtw_fw_state *fw) +static int __rtw_download_firmware(struct rtw_dev *rtwdev, struct rtw_fw_state *fw) { struct rtw_backup_info bckp[DLFW_RESTORE_REG_NUM]; const u8 *data = fw->firmware->data; @@ -860,7 +860,7 @@ static int download_firmware_validate_legacy(struct rtw_dev *rtwdev) return -EINVAL; } -int __rtw_download_firmware_legacy(struct rtw_dev *rtwdev, struct rtw_fw_state *fw) +static int __rtw_download_firmware_legacy(struct rtw_dev *rtwdev, struct rtw_fw_state *fw) { int ret = 0;
Fix the following warning: vers/net/wireless/realtek/rtw88/mac.c:699:5: warning: symbol '__rtw_download_firmware' was not declared. Should it be static? drivers/net/wireless/realtek/rtw88/mac.c:863:5: warning: symbol '__rtw_download_firmware_legacy' was not declared. Should it be static? Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: ChenTao <chentao107@huawei.com> --- drivers/net/wireless/realtek/rtw88/mac.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)