| Message ID | 1590144291-18526-1-git-send-email-yibin.gong@nxp.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 4fd6b5735c03c0955d93960d31f17d7144f5578f |
| Headers | show |
| Series | [v3,1/2] arm64: dts: imx8mm-evk: correct ldo1/ldo2 voltage range | expand |
On Thu, May 21, 2020 at 11:44 PM Robin Gong <yibin.gong@nxp.com> wrote: > > Correct ldo1 voltage range from wrong high group(3.0V~3.3V) to low group > (1.6V~1.9V) because the ldo1 should be 1.8V. Actually, two voltage groups > have been supported at bd718x7-regulator driver, hence, just corrrect the > voltage range to 1.6V~3.3V. For ldo2@0.8V, correct voltage range too. > Otherwise, ldo1 would be kept @3.0V and ldo2@0.9V which violate i.mx8mm > datasheet as the below warning log in kernel: > > [ 0.995524] LDO1: Bringing 1800000uV into 3000000-3000000uV > [ 0.999196] LDO2: Bringing 800000uV into 900000-900000uV > > Fixes: 78cc25fa265d ("arm64: dts: imx8mm-evk: Add BD71847 PMIC") > Cc: stable@vger.kernel.org > Signed-off-by: Robin Gong <yibin.gong@nxp.com> > Reviewed-by: Dong Aisheng <aisheng.dong@nxp.com> Reviewed-by: Fabio Estevam <festevam@gmail.com>
On Fri, May 22, 2020 at 06:44:50PM +0800, Robin Gong wrote: > Correct ldo1 voltage range from wrong high group(3.0V~3.3V) to low group > (1.6V~1.9V) because the ldo1 should be 1.8V. Actually, two voltage groups > have been supported at bd718x7-regulator driver, hence, just corrrect the > voltage range to 1.6V~3.3V. For ldo2@0.8V, correct voltage range too. > Otherwise, ldo1 would be kept @3.0V and ldo2@0.9V which violate i.mx8mm > datasheet as the below warning log in kernel: > > [ 0.995524] LDO1: Bringing 1800000uV into 3000000-3000000uV > [ 0.999196] LDO2: Bringing 800000uV into 900000-900000uV > > Fixes: 78cc25fa265d ("arm64: dts: imx8mm-evk: Add BD71847 PMIC") > Cc: stable@vger.kernel.org > Signed-off-by: Robin Gong <yibin.gong@nxp.com> > Reviewed-by: Dong Aisheng <aisheng.dong@nxp.com> Applied both, thanks.
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts index e5ec832..0f1d7f8 100644 --- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts +++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts @@ -208,7 +208,7 @@ ldo1_reg: LDO1 { regulator-name = "LDO1"; - regulator-min-microvolt = <3000000>; + regulator-min-microvolt = <1600000>; regulator-max-microvolt = <3300000>; regulator-boot-on; regulator-always-on; @@ -216,7 +216,7 @@ ldo2_reg: LDO2 { regulator-name = "LDO2"; - regulator-min-microvolt = <900000>; + regulator-min-microvolt = <800000>; regulator-max-microvolt = <900000>; regulator-boot-on; regulator-always-on;
Correct ldo1 voltage range from wrong high group(3.0V~3.3V) to low group (1.6V~1.9V) because the ldo1 should be 1.8V. Actually, two voltage groups have been supported at bd718x7-regulator driver, hence, just corrrect the voltage range to 1.6V~3.3V. For ldo2@0.8V, correct voltage range too. Otherwise, ldo1 would be kept @3.0V and ldo2@0.9V which violate i.mx8mm datasheet as the below warning log in kernel: [ 0.995524] LDO1: Bringing 1800000uV into 3000000-3000000uV [ 0.999196] LDO2: Bringing 800000uV into 900000-900000uV Fixes: 78cc25fa265d ("arm64: dts: imx8mm-evk: Add BD71847 PMIC") Cc: stable@vger.kernel.org Signed-off-by: Robin Gong <yibin.gong@nxp.com> Reviewed-by: Dong Aisheng <aisheng.dong@nxp.com> --- arch/arm64/boot/dts/freescale/imx8mm-evk.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)