| Message ID | 20200528205727.20309-1-chris@chris-wilson.co.uk (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/i915/gt: Start timeslice on partial submission | expand |
Chris Wilson <chris@chris-wilson.co.uk> writes: > We may choose to only submit ELSP[0], even though we have sufficient > requests to fill the whole ELSP. Normally, we only start timeslicing if > we fill more than one port, but in this case we need to start > timeslicing for the queue that we choose not to submit. If this is last in a line, it makes sense to make sure that we get woken up. Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com> > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> > Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> > --- > drivers/gpu/drm/i915/gt/intel_lrc.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/gt/intel_lrc.c b/drivers/gpu/drm/i915/gt/intel_lrc.c > index 69fff36ec0cc..6fc0966b75ff 100644 > --- a/drivers/gpu/drm/i915/gt/intel_lrc.c > +++ b/drivers/gpu/drm/i915/gt/intel_lrc.c > @@ -2358,8 +2358,10 @@ static void execlists_dequeue(struct intel_engine_cs *engine) > if (last->context == rq->context) > goto done; > > - if (i915_request_has_sentinel(last)) > + if (i915_request_has_sentinel(last)) { > + start_timeslice(engine, rq_prio(rq)); > goto done; > + } > > /* > * If GVT overrides us we only ever submit > -- > 2.20.1 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
diff --git a/drivers/gpu/drm/i915/gt/intel_lrc.c b/drivers/gpu/drm/i915/gt/intel_lrc.c index 69fff36ec0cc..6fc0966b75ff 100644 --- a/drivers/gpu/drm/i915/gt/intel_lrc.c +++ b/drivers/gpu/drm/i915/gt/intel_lrc.c @@ -2358,8 +2358,10 @@ static void execlists_dequeue(struct intel_engine_cs *engine) if (last->context == rq->context) goto done; - if (i915_request_has_sentinel(last)) + if (i915_request_has_sentinel(last)) { + start_timeslice(engine, rq_prio(rq)); goto done; + } /* * If GVT overrides us we only ever submit
We may choose to only submit ELSP[0], even though we have sufficient requests to fill the whole ELSP. Normally, we only start timeslicing if we fill more than one port, but in this case we need to start timeslicing for the queue that we choose not to submit. Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> --- drivers/gpu/drm/i915/gt/intel_lrc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)