Message ID | 20200615090943.2936839-1-noltari@gmail.com (mailing list archive) |
---|---|
Headers | show |
Series | spi: bcm63xx: add BMIPS support | expand |
On Mon, Jun 15, 2020 at 11:09:39AM +0200, Álvaro Fernández Rojas wrote: > BCM63xx SPI and HSSPI controller are present on several BMIPS SoCs (BCM6318, > BCM6328, BCM6358, BCM6362, BCM6368 and BCM63268). Please don't send new versions of patches in reply to old ones, it makes it hard to keep track of what's going on and can bury things back in a mailbox.
Hi Alvaro, On 6/15/2020 2:09 AM, Álvaro Fernández Rojas wrote: > BCM63xx SPI and HSSPI controller are present on several BMIPS SoCs (BCM6318, > BCM6328, BCM6358, BCM6362, BCM6368 and BCM63268). > > v2: use devm_reset_control_get_exclusive We would also need to write a binding document for these two controllers, as they appear to be missing, and this would document the reset property. I also believe that you should be making this property optional since not all SoCs do have a dedicated reset controller line for SPI/HSSPI (if at all). Thank you!