diff mbox series

[v4,1/7] MAINTAINERS: Cover 'hw/sh4/sh_intc.h' with the R2D machine

Message ID 20200611114317.13044-2-f4bug@amsat.org (mailing list archive)
State New, archived
Headers show
Series sh4: Add 'Renesas peripherals' entry in MAINTAINERS + trivial fixes | expand

Commit Message

Philippe Mathieu-Daudé June 11, 2020, 11:43 a.m. UTC
Commit 81527b94ad added hw/intc/sh_intc.c, complete by
adding its corresponding header.

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

Comments

Thomas Huth June 16, 2020, 1:34 p.m. UTC | #1
On 11/06/2020 13.43, Philippe Mathieu-Daudé wrote:
> Commit 81527b94ad added hw/intc/sh_intc.c, complete by
> adding its corresponding header.
> 
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 13711aafe8..87ceca7ff1 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1257,6 +1257,7 @@ S: Maintained
>  F: hw/sh4/r2d.c
>  F: hw/intc/sh_intc.c
>  F: hw/timer/sh_timer.c
> +F: include/hw/sh4/sh_intc.h
>  
>  Shix
>  M: Yoshinori Sato <ysato@users.sourceforge.jp>

Hmm, sh_intc.h is used by sh7750_init() in sh7750.c ... and that
function is used by both, r2d and shix machines ... so should that maybe
rather be part of both machines or a generic entry?

 Thomas
Philippe Mathieu-Daudé June 16, 2020, 2:49 p.m. UTC | #2
On 6/16/20 3:34 PM, Thomas Huth wrote:
> On 11/06/2020 13.43, Philippe Mathieu-Daudé wrote:
>> Commit 81527b94ad added hw/intc/sh_intc.c, complete by
>> adding its corresponding header.
>>
>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>> ---
>>  MAINTAINERS | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 13711aafe8..87ceca7ff1 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -1257,6 +1257,7 @@ S: Maintained
>>  F: hw/sh4/r2d.c
>>  F: hw/intc/sh_intc.c
>>  F: hw/timer/sh_timer.c
>> +F: include/hw/sh4/sh_intc.h
>>  
>>  Shix
>>  M: Yoshinori Sato <ysato@users.sourceforge.jp>
> 
> Hmm, sh_intc.h is used by sh7750_init() in sh7750.c ... and that
> function is used by both, r2d and shix machines ... so should that maybe
> rather be part of both machines or a generic entry?

I'll add it to both machines. The maintainers can reorder
the sections later.

Thanks for the review!

> 
>  Thomas
> 
>
Thomas Huth June 16, 2020, 3:56 p.m. UTC | #3
On 16/06/2020 16.49, Philippe Mathieu-Daudé wrote:
> On 6/16/20 3:34 PM, Thomas Huth wrote:
>> On 11/06/2020 13.43, Philippe Mathieu-Daudé wrote:
>>> Commit 81527b94ad added hw/intc/sh_intc.c, complete by
>>> adding its corresponding header.
>>>
>>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>>> ---
>>>  MAINTAINERS | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>> index 13711aafe8..87ceca7ff1 100644
>>> --- a/MAINTAINERS
>>> +++ b/MAINTAINERS
>>> @@ -1257,6 +1257,7 @@ S: Maintained
>>>  F: hw/sh4/r2d.c
>>>  F: hw/intc/sh_intc.c
>>>  F: hw/timer/sh_timer.c
>>> +F: include/hw/sh4/sh_intc.h
>>>  
>>>  Shix
>>>  M: Yoshinori Sato <ysato@users.sourceforge.jp>
>>
>> Hmm, sh_intc.h is used by sh7750_init() in sh7750.c ... and that
>> function is used by both, r2d and shix machines ... so should that maybe
>> rather be part of both machines or a generic entry?
> 
> I'll add it to both machines. The maintainers can reorder
> the sections later.
> 
> Thanks for the review!

Ok, with that change:
Reviewed-by: Thomas Huth <thuth@redhat.com>
diff mbox series

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index 13711aafe8..87ceca7ff1 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1257,6 +1257,7 @@  S: Maintained
 F: hw/sh4/r2d.c
 F: hw/intc/sh_intc.c
 F: hw/timer/sh_timer.c
+F: include/hw/sh4/sh_intc.h
 
 Shix
 M: Yoshinori Sato <ysato@users.sourceforge.jp>