| Message ID | 20200625204730.943520-1-christophe.jaillet@wanadoo.fr (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 040ab9c4fd0070cd5fa71ba3a7b95b8470db9b4d |
| Headers | show |
| Series | scsi: cumana_2: Fix different dev_id between 'request_irq()' and 'free_irq()' | expand |
On Thu, Jun 25, 2020 at 10:47:30PM +0200, Christophe JAILLET wrote: > The dev_id used in 'request_irq()' and 'free_irq()' should match. > Use 'info' in both cases. > > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Acked-by: Russell King <rmk+kernel@armlinux.org.uk> Thanks Christophe. > --- > V2: update free_irq instead of request_irq in order not to obviously break > code > --- > drivers/scsi/arm/cumana_2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/arm/cumana_2.c b/drivers/scsi/arm/cumana_2.c > index 65691c21f133..29294f0ef8a9 100644 > --- a/drivers/scsi/arm/cumana_2.c > +++ b/drivers/scsi/arm/cumana_2.c > @@ -450,7 +450,7 @@ static int cumanascsi2_probe(struct expansion_card *ec, > > if (info->info.scsi.dma != NO_DMA) > free_dma(info->info.scsi.dma); > - free_irq(ec->irq, host); > + free_irq(ec->irq, info); > > out_release: > fas216_release(host); > -- > 2.25.1 > >
On Thu, 25 Jun 2020 22:47:30 +0200, Christophe JAILLET wrote: > The dev_id used in 'request_irq()' and 'free_irq()' should match. > Use 'info' in both cases. Applied to 5.9/scsi-queue, thanks! [1/1] scsi: cumana_2: Fix different dev_id between request_irq() and free_irq() https://git.kernel.org/mkp/scsi/c/040ab9c4fd00
diff --git a/drivers/scsi/arm/cumana_2.c b/drivers/scsi/arm/cumana_2.c index 65691c21f133..29294f0ef8a9 100644 --- a/drivers/scsi/arm/cumana_2.c +++ b/drivers/scsi/arm/cumana_2.c @@ -450,7 +450,7 @@ static int cumanascsi2_probe(struct expansion_card *ec, if (info->info.scsi.dma != NO_DMA) free_dma(info->info.scsi.dma); - free_irq(ec->irq, host); + free_irq(ec->irq, info); out_release: fas216_release(host);
The dev_id used in 'request_irq()' and 'free_irq()' should match. Use 'info' in both cases. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> --- V2: update free_irq instead of request_irq in order not to obviously break code --- drivers/scsi/arm/cumana_2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)