diff mbox series

arm64: dts: renesas: cat875: Drop superfluous phy-mode

Message ID 20200706151400.23105-1-geert+renesas@glider.be (mailing list archive)
State Mainlined
Commit 273f00a1ece8f5d7647a77e33f8548720bbc5344
Delegated to: Geert Uytterhoeven
Headers show
Series arm64: dts: renesas: cat875: Drop superfluous phy-mode | expand

Commit Message

Geert Uytterhoeven July 6, 2020, 3:14 p.m. UTC
The PHY mode already defaults to RGMII in the RZ/G2E base SoC DTS file,
so there is no need to specify the same value in board files.

Fixes: 6b170cd3ed02949f ("arm64: dts: renesas: cat875: Add ethernet support")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 arch/arm64/boot/dts/renesas/cat875.dtsi | 1 -
 1 file changed, 1 deletion(-)

Comments

Lad Prabhakar July 6, 2020, 3:40 p.m. UTC | #1
Hi Geert,

Thank you for the patch.

> -----Original Message-----
> From: Geert Uytterhoeven <geert+renesas@glider.be>
> Sent: 06 July 2020 16:14
> To: Magnus Damm <magnus.damm@gmail.com>; Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Cc: Chris Paterson <Chris.Paterson2@renesas.com>; linux-renesas-soc@vger.kernel.org; Geert Uytterhoeven <geert+renesas@glider.be>
> Subject: [PATCH] arm64: dts: renesas: cat875: Drop superfluous phy-mode
>
> The PHY mode already defaults to RGMII in the RZ/G2E base SoC DTS file,
> so there is no need to specify the same value in board files.
>
> Fixes: 6b170cd3ed02949f ("arm64: dts: renesas: cat875: Add ethernet support")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  arch/arm64/boot/dts/renesas/cat875.dtsi | 1 -
>  1 file changed, 1 deletion(-)
>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Cheers,
--Prabhakar

> diff --git a/arch/arm64/boot/dts/renesas/cat875.dtsi b/arch/arm64/boot/dts/renesas/cat875.dtsi
> index aaefc3ae56d50960..33daa95706840037 100644
> --- a/arch/arm64/boot/dts/renesas/cat875.dtsi
> +++ b/arch/arm64/boot/dts/renesas/cat875.dtsi
> @@ -18,7 +18,6 @@
>  pinctrl-names = "default";
>  renesas,no-ether-link;
>  phy-handle = <&phy0>;
> -phy-mode = "rgmii";
>  status = "okay";
>
>  phy0: ethernet-phy@0 {
> --
> 2.17.1



Renesas Electronics Europe GmbH, Geschaeftsfuehrer/President: Carsten Jauch, Sitz der Gesellschaft/Registered office: Duesseldorf, Arcadiastrasse 10, 40472 Duesseldorf, Germany, Handelsregister/Commercial Register: Duesseldorf, HRB 3708 USt-IDNr./Tax identification no.: DE 119353406 WEEE-Reg.-Nr./WEEE reg. no.: DE 14978647
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/renesas/cat875.dtsi b/arch/arm64/boot/dts/renesas/cat875.dtsi
index aaefc3ae56d50960..33daa95706840037 100644
--- a/arch/arm64/boot/dts/renesas/cat875.dtsi
+++ b/arch/arm64/boot/dts/renesas/cat875.dtsi
@@ -18,7 +18,6 @@ 
 	pinctrl-names = "default";
 	renesas,no-ether-link;
 	phy-handle = <&phy0>;
-	phy-mode = "rgmii";
 	status = "okay";
 
 	phy0: ethernet-phy@0 {