diff mbox series

arm: DT: vf610-zii-scu4-aib.dts: Configure fibre ports to 1000BaseX

Message ID CAFXsbZo3xXXgCSd4AgDs8U46hBR0+HkQgzsvwJ=B6rUiondydA@mail.gmail.com (mailing list archive)
State New, archived
Headers show
Series arm: DT: vf610-zii-scu4-aib.dts: Configure fibre ports to 1000BaseX | expand

Commit Message

Chris Healy July 6, 2020, 1:02 a.m. UTC 
The SFF soldered onto the board expect the ports to use 1000BaseX.  It
makes no sense to have the ports set to SGMII, since they don't even
support that mode.

Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Chris Healy <cphealy@gmail.com>
---
 arch/arm/boot/dts/vf610-zii-scu4-aib.dts | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

Comments

Fabio Estevam July 6, 2020, 11:17 p.m. UTC | #1 
Hi Chris,

Subject style is usually:

ARM: dts: vf610-zii-scu4-aib: Configure fibre ports to 1000BaseX

On Sun, Jul 5, 2020 at 10:02 PM Chris Healy <cphealy@gmail.com> wrote:
>
> The SFF soldered onto the board expect the ports to use 1000BaseX.  It
> makes no sense to have the ports set to SGMII, since they don't even
> support that mode.
>
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> Signed-off-by: Chris Healy <cphealy@gmail.com>

Not clear here if the original Author is Andrew and you are forwarding
his patch.

If this is the case, then Andrew's name should appear in the From line.
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/vf610-zii-scu4-aib.dts
b/arch/arm/boot/dts/vf610-zii-scu4-aib.dts
index b642520199ba..040a1f8b6130 100644
--- a/arch/arm/boot/dts/vf610-zii-scu4-aib.dts
+++ b/arch/arm/boot/dts/vf610-zii-scu4-aib.dts
@@ -186,7 +186,7 @@ 
                     port@2 {
                         reg = <2>;
                         label = "eth_fc_1000_2";
-                        phy-mode = "sgmii";
+                        phy-mode = "1000base-x";
                         managed = "in-band-status";
                         sfp = <&sff1>;
                     };
@@ -194,7 +194,7 @@ 
                     port@3 {
                         reg = <3>;
                         label = "eth_fc_1000_3";
-                        phy-mode = "sgmii";
+                        phy-mode = "1000base-x";
                         managed = "in-band-status";
                         sfp = <&sff2>;
                     };
@@ -202,7 +202,7 @@ 
                     port@4 {
                         reg = <4>;
                         label = "eth_fc_1000_4";
-                        phy-mode = "sgmii";
+                        phy-mode = "1000base-x";
                         managed = "in-band-status";
                         sfp = <&sff3>;
                     };
@@ -210,7 +210,7 @@ 
                     port@5 {
                         reg = <5>;
                         label = "eth_fc_1000_5";
-                        phy-mode = "sgmii";
+                        phy-mode = "1000base-x";
                         managed = "in-band-status";
                         sfp = <&sff4>;
                     };
@@ -218,7 +218,7 @@ 
                     port@6 {
                         reg = <6>;
                         label = "eth_fc_1000_6";
-                        phy-mode = "sgmii";
+                        phy-mode = "1000base-x";
                         managed = "in-band-status";
                         sfp = <&sff5>;
                     };
@@ -226,7 +226,7 @@ 
                     port@7 {
                         reg = <7>;
                         label = "eth_fc_1000_7";
-                        phy-mode = "sgmii";
+                        phy-mode = "1000base-x";
                         managed = "in-band-status";
                         sfp = <&sff6>;
                     };
@@ -234,7 +234,7 @@ 
                     port@9 {
                         reg = <9>;
                         label = "eth_fc_1000_1";
-                        phy-mode = "sgmii";
+                        phy-mode = "1000base-x";
                         managed = "in-band-status";
                         sfp = <&sff0>;
                     };
@@ -269,7 +269,7 @@ 
                     port@2 {
                         reg = <2>;
                         label = "eth_fc_1000_8";
-                        phy-mode = "sgmii";
+                        phy-mode = "1000base-x";
                         managed = "in-band-status";
                         sfp = <&sff7>;
                     };
@@ -277,7 +277,7 @@ 
                     port@3 {
                         reg = <3>;
                         label = "eth_fc_1000_9";
-                        phy-mode = "sgmii";
+                        phy-mode = "1000base-x";
                         managed = "in-band-status";
                         sfp = <&sff8>;
                     };
@@ -285,7 +285,7 @@ 
                     port@4 {
                         reg = <4>;
                         label = "eth_fc_1000_10";
-                        phy-mode = "sgmii";
+                        phy-mode = "1000base-x";
                         managed = "in-band-status";
                         sfp = <&sff9>;
                     };