[v4,36/40] gitlab: split build-disabled into two phases

Commit Message

Alex Bennée July 1, 2020, 1:56 p.m. UTC

As we run check-qtest in "SLOW" mode this can timeout so split into
two jobs.

Signed-off-by: Alex Bennée <[e-mail]>
Reviewed-by: Philippe Mathieu-Daudé <[e-mail]>
Reviewed-by: Thomas Huth <[e-mail]>

---
v4
  - rename :->-
---
 .gitlab-ci.yml | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

Comments

Thomas Huth July 10, 2020, 1:16 p.m. UTC | #1

On 01/07/2020 15.56, Alex Bennée wrote:
> As we run check-qtest in "SLOW" mode this can timeout so split into
> two jobs.
> 
> Signed-off-by: Alex Bennée <[e-mail]>
> Reviewed-by: Philippe Mathieu-Daudé <[e-mail]>
> Reviewed-by: Thomas Huth <[e-mail]>

 Hi Alex,

I think you can drop this patch and use "[PATCH v2] tests: improve
performance of device-introspect-test" instead.

 Thanks,
  Thomas

Alex Bennée July 10, 2020, 2:58 p.m. UTC | #2

Thomas Huth <[e-mail]> writes:

> On 01/07/2020 15.56, Alex Bennée wrote:
>> As we run check-qtest in "SLOW" mode this can timeout so split into
>> two jobs.
>> 
>> Signed-off-by: Alex Bennée <[e-mail]>
>> Reviewed-by: Philippe Mathieu-Daudé <[e-mail]>
>> Reviewed-by: Thomas Huth <[e-mail]>
>
>  Hi Alex,
>
> I think you can drop this patch and use "[PATCH v2] tests: improve
> performance of device-introspect-test" instead.

As I'm re-rolling the PR sure...

>
>  Thanks,
>   Thomas

Philippe Mathieu-Daudé July 10, 2020, 4:01 p.m. UTC | #3

On 7/10/20 4:58 PM, Alex Bennée wrote:
> 
> Thomas Huth <[e-mail]> writes:
> 
>> On 01/07/2020 15.56, Alex Bennée wrote:
>>> As we run check-qtest in "SLOW" mode this can timeout so split into
>>> two jobs.
>>>
>>> Signed-off-by: Alex Bennée <[e-mail]>
>>> Reviewed-by: Philippe Mathieu-Daudé <[e-mail]>
>>> Reviewed-by: Thomas Huth <[e-mail]>
>>
>>  Hi Alex,
>>
>> I think you can drop this patch and use "[PATCH v2] tests: improve
>> performance of device-introspect-test" instead.
> 
> As I'm re-rolling the PR sure...

Also maybe:

https://www.mail-archive.com/[e-mail]/msg721458.html

Alex Bennée July 10, 2020, 4:26 p.m. UTC | #4

Philippe Mathieu-Daudé <[e-mail]> writes:

> On 7/10/20 4:58 PM, Alex Bennée wrote:
>> 
>> Thomas Huth <[e-mail]> writes:
>> 
>>> On 01/07/2020 15.56, Alex Bennée wrote:
>>>> As we run check-qtest in "SLOW" mode this can timeout so split into
>>>> two jobs.
>>>>
>>>> Signed-off-by: Alex Bennée <[e-mail]>
>>>> Reviewed-by: Philippe Mathieu-Daudé <[e-mail]>
>>>> Reviewed-by: Thomas Huth <[e-mail]>
>>>
>>>  Hi Alex,
>>>
>>> I think you can drop this patch and use "[PATCH v2] tests: improve
>>> performance of device-introspect-test" instead.
>> 
>> As I'm re-rolling the PR sure...
>
> Also maybe:
>
> https://www.mail-archive.com/[e-mail]/msg721458.html

I don't think it's directly related - can we just avoid pilling a bunch
of stuff in on a re-roll please.

Philippe Mathieu-Daudé July 10, 2020, 4:53 p.m. UTC | #5

On 7/10/20 6:26 PM, Alex Bennée wrote:
> 
> Philippe Mathieu-Daudé <[e-mail]> writes:
> 
>> On 7/10/20 4:58 PM, Alex Bennée wrote:
>>>
>>> Thomas Huth <[e-mail]> writes:
>>>
>>>> On 01/07/2020 15.56, Alex Bennée wrote:
>>>>> As we run check-qtest in "SLOW" mode this can timeout so split into
>>>>> two jobs.
>>>>>
>>>>> Signed-off-by: Alex Bennée <[e-mail]>
>>>>> Reviewed-by: Philippe Mathieu-Daudé <[e-mail]>
>>>>> Reviewed-by: Thomas Huth <[e-mail]>
>>>>
>>>>  Hi Alex,
>>>>
>>>> I think you can drop this patch and use "[PATCH v2] tests: improve
>>>> performance of device-introspect-test" instead.
>>>
>>> As I'm re-rolling the PR sure...
>>
>> Also maybe:
>>
>> https://www.mail-archive.com/[e-mail]/msg721458.html
> 
> I don't think it's directly related

I thought it was.

> - can we just avoid pilling a bunch
> of stuff in on a re-roll please.

Understood, sorry.

Patch

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 13e9531724d..83e38ea19f3 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -113,7 +113,7 @@  acceptance-system-fedora-alt:
     MAKE_CHECK_ARGS: check-acceptance
   <<: *post_acceptance
 
-build-disabled:
+build-system-fedora-disabled:
   <<: *native_build_job_definition
   variables:
     IMAGE: fedora
@@ -124,6 +124,17 @@  build-disabled:
       --disable-qom-cast-debug --disable-spice --disable-vhost-vsock
       --disable-vhost-net --disable-vhost-crypto --disable-vhost-user
     TARGETS: i386-softmmu ppc64-softmmu mips64-softmmu i386-linux-user
+  artifacts:
+    paths:
+      - build
+
+qtest-system-fedora-disabled:
+  <<: *native_test_job_definition
+  needs:
+    - job: build-system-fedora-disabled
+      artifacts: true
+  variables:
+    IMAGE: fedora
     MAKE_CHECK_ARGS: check-qtest SPEED=slow
 
 build-tcg-disabled: