diff mbox series

[1/4] xfs_repair: alphabetize HFILES and CFILES

Message ID 159476317341.3156699.9021466334498861961.stgit@magnolia (mailing list archive)
State Accepted
Headers show
Series xfs_repair: check quota counters | expand

Commit Message

Darrick J. Wong July 14, 2020, 9:46 p.m. UTC 
From: Darrick J. Wong <darrick.wong@oracle.com>

Convert the definitions of HFILES and CFILES to lists that can be sorted
easily (in vim, anyway), then fix the alphabetization of the makefile
targets.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
 repair/Makefile |   67 ++++++++++++++++++++++++++++++++++++++++++++++++-------
 1 file changed, 58 insertions(+), 9 deletions(-)

Comments

Christoph Hellwig July 15, 2020, 5:47 p.m. UTC | #1 
On Tue, Jul 14, 2020 at 02:46:13PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
> 
> Convert the definitions of HFILES and CFILES to lists that can be sorted
> easily (in vim, anyway), then fix the alphabetization of the makefile
> targets.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>
diff mbox series

Patch

diff --git a/repair/Makefile b/repair/Makefile
index f6a6e3f9..e9f93202 100644
--- a/repair/Makefile
+++ b/repair/Makefile
@@ -9,16 +9,65 @@  LSRCFILES = README
 
 LTCOMMAND = xfs_repair
 
-HFILES = agheader.h agbtree.h attr_repair.h avl.h bulkload.h bmap.h btree.h \
-	da_util.h dinode.h dir2.h err_protos.h globals.h incore.h protos.h \
-	rt.h progress.h scan.h versions.h prefetch.h rmap.h slab.h threads.h
+HFILES = \
+	agheader.h \
+	agbtree.h \
+	attr_repair.h \
+	avl.h \
+	bulkload.h \
+	bmap.h \
+	btree.h \
+	da_util.h \
+	dinode.h \
+	dir2.h \
+	err_protos.h \
+	globals.h \
+	incore.h \
+	prefetch.h \
+	progress.h \
+	protos.h \
+	rmap.h \
+	rt.h \
+	scan.h \
+	slab.h \
+	threads.h \
+	versions.h
 
-CFILES = agheader.c agbtree.c attr_repair.c avl.c bulkload.c bmap.c btree.c \
-	da_util.c dino_chunks.c dinode.c dir2.c globals.c incore.c \
-	incore_bmc.c init.c incore_ext.c incore_ino.c phase1.c \
-	phase2.c phase3.c phase4.c phase5.c phase6.c phase7.c \
-	progress.c prefetch.c rmap.c rt.c sb.c scan.c slab.c threads.c \
-	versions.c xfs_repair.c
+CFILES = \
+	agheader.c \
+	agbtree.c \
+	attr_repair.c \
+	avl.c \
+	bulkload.c \
+	bmap.c \
+	btree.c \
+	da_util.c \
+	dino_chunks.c \
+	dinode.c \
+	dir2.c \
+	globals.c \
+	incore_bmc.c \
+	incore.c \
+	incore_ext.c \
+	incore_ino.c \
+	init.c \
+	phase1.c \
+	phase2.c \
+	phase3.c \
+	phase4.c \
+	phase5.c \
+	phase6.c \
+	phase7.c \
+	prefetch.c \
+	progress.c \
+	rmap.c \
+	rt.c \
+	sb.c \
+	scan.c \
+	slab.c \
+	threads.c \
+	versions.c \
+	xfs_repair.c
 
 LLDLIBS = $(LIBXFS) $(LIBXLOG) $(LIBXCMD) $(LIBFROG) $(LIBUUID) $(LIBRT) \
 	$(LIBPTHREAD) $(LIBBLKID)