| Message ID | 20200722142515.897378-1-jic23@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | iio:dac:ad5592r: Fix use of true for IIO_SHARED_BY_TYPE | expand |
On Wed, Jul 22, 2020 at 5:28 PM Jonathan Cameron <jic23@kernel.org> wrote: > > From: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > struct iio_chan_spec_ext_info shared element is of type > enum iio_shared_by, not boolean. It's like the enum value > will for IIO_SHARED_BY_TYPE == 1 == true, hence no actual > problem has been observed. > > CC [M] drivers/iio/dac/ad5592r-base.o > drivers/iio/dac/ad5592r-base.c:491:13: warning: implicit conversion from ‘enum <anonymous>’ to ‘enum iio_shared_by’ [-Wenum-conversion] > 491 | .shared = true, > | > Fixes: 56ca9db862bf ("iio: dac: Add support for the AD5592R/AD5593R ADCs/DACs") > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > Cc: Alexandru Ardelean <alexandru.ardelean@analog.com> > --- > drivers/iio/dac/ad5592r-base.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/dac/ad5592r-base.c b/drivers/iio/dac/ad5592r-base.c > index cc4875660a69..456bf5292c44 100644 > --- a/drivers/iio/dac/ad5592r-base.c > +++ b/drivers/iio/dac/ad5592r-base.c > @@ -488,7 +488,7 @@ static const struct iio_chan_spec_ext_info ad5592r_ext_info[] = { > { > .name = "scale_available", > .read = ad5592r_show_scale_available, > - .shared = true, > + .shared = IIO_SHARED_BY_TYPE, Acked-by: Alexandru Ardelean <alexandru.ardelean@analog.com> > }, > {}, > }; > -- > 2.27.0 >
On Thu, 23 Jul 2020 08:59:17 +0300 Alexandru Ardelean <ardeleanalex@gmail.com> wrote: > On Wed, Jul 22, 2020 at 5:28 PM Jonathan Cameron <jic23@kernel.org> wrote: > > > > From: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > > > struct iio_chan_spec_ext_info shared element is of type > > enum iio_shared_by, not boolean. It's like the enum value > > will for IIO_SHARED_BY_TYPE == 1 == true, hence no actual > > problem has been observed. > > > > CC [M] drivers/iio/dac/ad5592r-base.o > > drivers/iio/dac/ad5592r-base.c:491:13: warning: implicit conversion from ‘enum <anonymous>’ to ‘enum iio_shared_by’ [-Wenum-conversion] > > 491 | .shared = true, > > | > > Fixes: 56ca9db862bf ("iio: dac: Add support for the AD5592R/AD5593R ADCs/DACs") > > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > Cc: Alexandru Ardelean <alexandru.ardelean@analog.com> > > --- > > drivers/iio/dac/ad5592r-base.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/iio/dac/ad5592r-base.c b/drivers/iio/dac/ad5592r-base.c > > index cc4875660a69..456bf5292c44 100644 > > --- a/drivers/iio/dac/ad5592r-base.c > > +++ b/drivers/iio/dac/ad5592r-base.c > > @@ -488,7 +488,7 @@ static const struct iio_chan_spec_ext_info ad5592r_ext_info[] = { > > { > > .name = "scale_available", > > .read = ad5592r_show_scale_available, > > - .shared = true, > > + .shared = IIO_SHARED_BY_TYPE, > > Acked-by: Alexandru Ardelean <alexandru.ardelean@analog.com> Applied to the togreg branch of iio.git and pushed out as testing etc. Ignore the fact I sent the same patch again having lost this version in my own email. oops Jonathan > > > }, > > {}, > > }; > > -- > > 2.27.0 > >
diff --git a/drivers/iio/dac/ad5592r-base.c b/drivers/iio/dac/ad5592r-base.c index cc4875660a69..456bf5292c44 100644 --- a/drivers/iio/dac/ad5592r-base.c +++ b/drivers/iio/dac/ad5592r-base.c @@ -488,7 +488,7 @@ static const struct iio_chan_spec_ext_info ad5592r_ext_info[] = { { .name = "scale_available", .read = ad5592r_show_scale_available, - .shared = true, + .shared = IIO_SHARED_BY_TYPE, }, {}, };