| Message ID | 20200723204244.24457-16-Larry.Finger@lwfinger.net (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | rtlwifi: Change RT_TRACE into rtl_dbg for all drivers | expand |
Hi Larry,
I love your patch! Yet something to improve:
[auto build test ERROR on wireless-drivers-next/master]
[also build test ERROR on wireless-drivers/master v5.8-rc6]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Larry-Finger/rtlwifi-Change-RT_TRACE-into-rtl_dbg-for-all-drivers/20200724-044910
base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master
config: parisc-allyesconfig (attached as .config)
compiler: hppa-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=parisc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
hppa-linux-ld: drivers/net/wireless/realtek/rtlwifi/base.o: in function `rtl_tx_mgmt_proc':
>> (.text+0x720): undefined reference to `_rtl_dbg_out'
hppa-linux-ld: drivers/net/wireless/realtek/rtlwifi/base.o: in function `rtl_rx_ampdu_apply':
(.text+0x830): undefined reference to `_rtl_dbg_out'
hppa-linux-ld: drivers/net/wireless/realtek/rtlwifi/base.o: in function `rtl_tx_status':
(.text+0x910): undefined reference to `_rtl_dbg_out'
>> hppa-linux-ld: (.text+0x940): undefined reference to `_rtl_dbg_out'
hppa-linux-ld: drivers/net/wireless/realtek/rtlwifi/base.o: in function `rtl_tx_report_handler':
(.text+0xb70): undefined reference to `_rtl_dbg_out'
hppa-linux-ld: drivers/net/wireless/realtek/rtlwifi/base.o:(.text+0xcb0): more undefined references to `_rtl_dbg_out' follow
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
Hi Larry,
I love your patch! Yet something to improve:
[auto build test ERROR on wireless-drivers-next/master]
[also build test ERROR on wireless-drivers/master v5.8-rc6]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Larry-Finger/rtlwifi-Change-RT_TRACE-into-rtl_dbg-for-all-drivers/20200724-044910
base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master
config: parisc-allmodconfig (attached as .config)
compiler: hppa-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=parisc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>, old ones prefixed by <<):
>> ERROR: modpost: "_rtl_dbg_out" [drivers/net/wireless/realtek/rtlwifi/rtl8192ee/rtl8192ee.ko] undefined!
>> ERROR: modpost: "_rtl_dbg_out" [drivers/net/wireless/realtek/rtlwifi/rtl8821ae/rtl8821ae.ko] undefined!
>> ERROR: modpost: "_rtl_dbg_out" [drivers/net/wireless/realtek/rtlwifi/rtl8723com/rtl8723-common.ko] undefined!
>> ERROR: modpost: "_rtl_dbg_out" [drivers/net/wireless/realtek/rtlwifi/btcoexist/btcoexist.ko] undefined!
>> ERROR: modpost: "_rtl_dbg_out" [drivers/net/wireless/realtek/rtlwifi/rtl8188ee/rtl8188ee.ko] undefined!
>> ERROR: modpost: "_rtl_dbg_out" [drivers/net/wireless/realtek/rtlwifi/rtl8723be/rtl8723be.ko] undefined!
>> ERROR: modpost: "_rtl_dbg_out" [drivers/net/wireless/realtek/rtlwifi/rtl8723ae/rtl8723ae.ko] undefined!
>> ERROR: modpost: "_rtl_dbg_out" [drivers/net/wireless/realtek/rtlwifi/rtl8192de/rtl8192de.ko] undefined!
>> ERROR: modpost: "_rtl_dbg_out" [drivers/net/wireless/realtek/rtlwifi/rtl8192se/rtl8192se.ko] undefined!
>> ERROR: modpost: "_rtl_dbg_out" [drivers/net/wireless/realtek/rtlwifi/rtl8192cu/rtl8192cu.ko] undefined!
>> ERROR: modpost: "_rtl_dbg_out" [drivers/net/wireless/realtek/rtlwifi/rtl8192ce/rtl8192ce.ko] undefined!
>> ERROR: modpost: "_rtl_dbg_out" [drivers/net/wireless/realtek/rtlwifi/rtl8192c/rtl8192c-common.ko] undefined!
>> ERROR: modpost: "_rtl_dbg_out" [drivers/net/wireless/realtek/rtlwifi/rtl_usb.ko] undefined!
>> ERROR: modpost: "_rtl_dbg_out" [drivers/net/wireless/realtek/rtlwifi/rtl_pci.ko] undefined!
>> ERROR: modpost: "_rtl_dbg_out" [drivers/net/wireless/realtek/rtlwifi/rtlwifi.ko] undefined!
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
Larry Finger <Larry.Finger@lwfinger.net> wrote: > A definition of this macro was kept until all drivers had been converted. > It can now be deleted. > > This change also renames _rtl_dbg_trace() to _rtl_dbg_out(). > > Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> > Reported-by: kernel test robot <lkp@intel.com> > Reported-by: kernel test robot <lkp@intel.com> Dropping patch 15 due to the reported build error, please resubmit that separately. Patch set to Changes Requested.
On 8/27/20 4:42 AM, Kalle Valo wrote: > Larry Finger <Larry.Finger@lwfinger.net> wrote: > >> A definition of this macro was kept until all drivers had been converted. >> It can now be deleted. >> >> This change also renames _rtl_dbg_trace() to _rtl_dbg_out(). >> >> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> >> Reported-by: kernel test robot <lkp@intel.com> >> Reported-by: kernel test robot <lkp@intel.com> > > Dropping patch 15 due to the reported build error, please resubmit that > separately. > > Patch set to Changes Requested. It turns out that patch 14 is also wrong. Please drop it as well. Would you prefer just those 2 or a v3 for all 15? Larry
Larry Finger <Larry.Finger@lwfinger.net> writes: > On 8/27/20 4:42 AM, Kalle Valo wrote: >> Larry Finger <Larry.Finger@lwfinger.net> wrote: >> >>> A definition of this macro was kept until all drivers had been converted. >>> It can now be deleted. >>> >>> This change also renames _rtl_dbg_trace() to _rtl_dbg_out(). >>> >>> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> >>> Reported-by: kernel test robot <lkp@intel.com> >>> Reported-by: kernel test robot <lkp@intel.com> >> >> Dropping patch 15 due to the reported build error, please resubmit that >> separately. >> >> Patch set to Changes Requested. > > It turns out that patch 14 is also wrong. Please drop it as well. > > Would you prefer just those 2 or a v3 for all 15? I can apply patches 1-13, but can't do it now as patchwork is down. But please do send patches 14-15 as v3.
diff --git a/drivers/net/wireless/realtek/rtlwifi/debug.h b/drivers/net/wireless/realtek/rtlwifi/debug.h index dbfb4d67ca31..6028f1ffa5da 100644 --- a/drivers/net/wireless/realtek/rtlwifi/debug.h +++ b/drivers/net/wireless/realtek/rtlwifi/debug.h @@ -149,8 +149,8 @@ enum dbgp_flag_e { struct rtl_priv; __printf(4, 5) -void _rtl_dbg_trace(struct rtl_priv *rtlpriv, u64 comp, int level, - const char *fmt, ...); +void _rtl_dbg_out(struct rtl_priv *rtlpriv, u64 comp, int level, + const char *fmt, ...); __printf(4, 5) void _rtl_dbg_print(struct rtl_priv *rtlpriv, u64 comp, int level, @@ -161,11 +161,7 @@ void _rtl_dbg_print_data(struct rtl_priv *rtlpriv, u64 comp, int level, const void *hexdata, int hexdatalen); #define rtl_dbg(rtlpriv, comp, level, fmt, ...) \ - _rtl_dbg_trace(rtlpriv, comp, level, \ - fmt, ##__VA_ARGS__) - -#define RT_TRACE(rtlpriv, comp, level, fmt, ...) \ - _rtl_dbg_trace(rtlpriv, comp, level, \ + _rtl_dbg_out(rtlpriv, comp, level, \ fmt, ##__VA_ARGS__) #define RTPRINT(rtlpriv, dbgtype, dbgflag, fmt, ...) \ @@ -187,13 +183,6 @@ static inline void rtl_dbg(struct rtl_priv *rtlpriv, { } -__printf(4, 5) -static inline void RT_TRACE(struct rtl_priv *rtlpriv, - u64 comp, int level, - const char *fmt, ...) -{ -} - __printf(4, 5) static inline void RTPRINT(struct rtl_priv *rtlpriv, int dbgtype, int dbgflag,
A definition of this macro was kept until all drivers had been converted. It can now be deleted. This change also renames _rtl_dbg_trace() to _rtl_dbg_out(). Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> --- v2 - the renaming of _rtl_dbg_trace was added --- drivers/net/wireless/realtek/rtlwifi/debug.h | 17 +++-------------- 1 file changed, 3 insertions(+), 14 deletions(-)